icrawl / action-eslint

🐋🐬 TypeScript/JavaScript ESLint action

I write code.

action-eslint's Issues

Need to be able to set working-directory

When using this action in a monorepo, I get the following error

##[error]Cannot find module '/home/runner/work/OWNER/REPO/node_modules/eslint'

This is because my app root is not in the root of my repo.

Monorepo support

It would be nice if src/ wasn't hardcoded:

action-eslint/src/main.ts

Line 17 in 66accb6

const report = cli.executeOnFiles(files || ['src']);

I would like to be able to run this in a monorepo (yarn workspaces), and configure what folders to run the checks in.

No files matching the pattern "src" were found

Thanks for the project! I started running into the following error after the latest update:

Added matchers: 'eslint-stylish'. Problem matchers scan action output for known warning or error strings and report these inline.
/opt/hostedtoolcache/node/12.14.1/x64/bin/node /home/runner/work/calm/calm/node_modules/eslint/bin/eslint --ext js,jsx,ts,tsx src
Oops! Something went wrong! :(
ESLint: 6.7.2.
No files matching the pattern "src" were found.
Please check for typing mistakes in the pattern.
##[error]Node run failed with exit code 1

I took a look at eslint-stylish to see if that might be the cause but nothing stood out to me. I think the eslint command with the src at the end is most likely the culprit.

Here is my lint.yml file:

name: ESLint

on:
  pull_request:
    branches:
      - master

jobs:
  eslint:
    name: Lint updated files
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v1
      - name: install node v12
        uses: actions/setup-node@v1
        with:
          node-version: 12
      - name: yarn install
        run: yarn install
        env:
          DATABASE_URL: ${{ secrets.DATABASE_URL }}
      - name: eslint
        uses: icrawl/action-eslint@v1
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          job-name: eslint
          default-dir: '.'

Setting it back to uses: icrawl/[email protected] made eslint run again for me.

accept normal eslint glob?

Right now because of the split on , I can't use a glob of say: **/*.{js,jsx,ts,tsx} which is the glob I use linting locally.

How to use with TS and angular?