Coder Social home page Coder Social logo

Comments (4)

quinnturner avatar quinnturner commented on July 24, 2024

This is definitely the desired behaviour 👍

from audit-ci.

quinnturner avatar quinnturner commented on July 24, 2024

IMO it would be best if we returned the exit code received from the original audit unless the exit code was non-zero due to a vulnerability that is whitelisted or below the specified level. This handles cases of other potential codes such as codes related to network errors, invalid registry, etc. At a minimum, it should return 1 if there's a non-whitelisted vulnerability above the level specified.

from audit-ci.

dubbha avatar dubbha commented on July 24, 2024

Currently exit code 0 is always returned no matter whether there are vulnerabilities or not.

Um.. Are you sure that is the case? I mean the whole idea of the wrapper is for it to fail

if there's a non-whitelisted vulnerability above the level specified

in a CI environment,which basically means it returns a non-zero exit-code. I am pretty sure that's exactly what's happening.

from audit-ci.

binarykitchen avatar binarykitchen commented on July 24, 2024

Sorry I was wrong. When it fails it returns exit code of 1. When it passed, it returns 0. To verify this, run the echo $? command afterwards.

from audit-ci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.