Comments (2)
Hi there, just trying to confirm the implementation here based on the logs that you've shown:
@optimizely/react-sdk
: if I recall the implementation correctly, allowlisting modules only allowlists direct advisories of the module itself. It will not work with transitive advisories. In this case, none of the advisories are@optimizely/react-sdk
itself. Rather, it's things likejson-schema
. If you want all transitives for@optimizely/react-sdk
, you'd do@optimizely/react-sdk>*
(I think that's how it works, it's late, forgetting off the top of my head :))@storybook/react
: same*|@storybook/addon-actions>*
none of these have the first level of advisory being@storybook/addon-actions
, so it won't allowlist.@svgr/webpack
same as first
I added some test cases in a WIP PR here to show scoped packages working: quinnturner#2.
from audit-ci.
Thanks for looking into this. I changed the config per your comment and they now all get allow listed. Thanks!
"allowlist": [
"*|@optimizely/react-sdk>*",
"*|@storybook/react>*",
"*|@storybook/addon-actions>*",
"*|@svgr/webpack>*",
"minimist"
]
from audit-ci.
Related Issues (20)
- Cannot convert undefined or null to object Exiting HOT 9
- Support allowlisting private packages by module HOT 7
- Recommend pinning to commit SHA or release tag HOT 3
- Add expiration time for allow list items HOT 1
- Allow notes for allowlist items HOT 2
- [Feature] Support Gitlab SAST report-type HOT 2
- Let the severity level influence the json output HOT 1
- Fail on unmatched ignores HOT 1
- Invalid JSON config file when using new allowlist NSPRecord syntax HOT 3
- Add support for registry flag for PNPM HOT 1
- Support Yarn's `--exclude` HOT 2
- Handle errors from Yarn Berry more gracefully HOT 2
- Tests should include all major Yarn versions HOT 2
- Replace event-stream with something secure and supported HOT 4
- The audit report format changed? HOT 2
- CI commands fail because no version 7 HOT 1
- Support Yarn v4 HOT 6
- v7 ignores command line arguments HOT 2
- SyntaxError: The requested module 'yargs/yargs' does not provide an export named 'default' HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from audit-ci.