Coder Social home page Coder Social logo

Comments (2)

quinnturner avatar quinnturner commented on August 28, 2024

Hi there, just trying to confirm the implementation here based on the logs that you've shown:

  • @optimizely/react-sdk: if I recall the implementation correctly, allowlisting modules only allowlists direct advisories of the module itself. It will not work with transitive advisories. In this case, none of the advisories are @optimizely/react-sdk itself. Rather, it's things like json-schema. If you want all transitives for @optimizely/react-sdk, you'd do @optimizely/react-sdk>* (I think that's how it works, it's late, forgetting off the top of my head :))
  • @storybook/react: same
  • *|@storybook/addon-actions>* none of these have the first level of advisory being @storybook/addon-actions, so it won't allowlist.
  • @svgr/webpack same as first

I added some test cases in a WIP PR here to show scoped packages working: quinnturner#2.

from audit-ci.

WhatIfWeDigDeeper avatar WhatIfWeDigDeeper commented on August 28, 2024

Thanks for looking into this. I changed the config per your comment and they now all get allow listed. Thanks!

  "allowlist": [
  "*|@optimizely/react-sdk>*",
  "*|@storybook/react>*",
  "*|@storybook/addon-actions>*",
  "*|@svgr/webpack>*",
  "minimist"
 ]

from audit-ci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.