iansimpson / ss-oauth2-server Goto Github PK
View Code? Open in Web Editor NEWAn OAuth 2.0 Server library for Silverstripe
License: MIT License
An OAuth 2.0 Server library for Silverstripe
License: MIT License
Hello @IanSimpson
thanks for building this OAuth lib! From having a look around the code it should be almost (already?) SS4 ready. Have you tested the module on SS4?
Cheers,
Peter
Not sure if this is on purpose, but the step where user would be asked to approve access to specific scopes is missing.
This is fine for me, as I have a very limited scope (just one resource - for "sso/profile"), use it exclusively for SSO, and I control both server and the client, but might not be so palatable if people want to use it as more full-fledged resource gatekeeper?
Would it make sense to put a note in README about that?
$member = \DataObject::get_by_id("Member", $request->getAttributes()['oauth_user_id']);
change to:
$member = \Member::get()->filter("ID", $request->getAttributes()['oauth_user_id'])->first();
I think UserEntity should not be a proxy global state because it could be dangerous or lead to confusion. As an example of how the problem can manifest see the comment here 2be7b46 .
It looks like the interface is intended to represent an actual object, so it should be tied explicitly and permanently to one concrete Member.
This is a bit arbitrary though - so asking for your feedback - is my concern legitimate?
Hello there
Thanks for the work. Are you actively working on this repository? If not, would it be ok to get a maintainer access to update the codebase? We have a few in-progress works such ask PHP 8.1 support that would be nice to have in a tagged release
https://github.com/torque-foxes/ss-oauth2-server
Thanks
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.