Comments (5)
Depending on timing issues across applications it looks like you could accidentally pickup the new service name in another process running on the same machine?
setEnv
modifies the process-internal environment mapping.
Only the process and any children should see the new variable name.
from hs-opentelemetry.
Another way that end users can work-around this is by using setEnv
.
withOtelServiceName :: String -> IO a -> IO a
withOtelServiceName newName action =
-- use bracket to restore the old service name
bracket (lookupEnv "OTEL_SERVICE_NAME") (setEnv "OTEL_SERVICE_NAME" . fromMaybe "") $ \maybeOldName -> do
setEnv "OTEL_SERVICE_NAME" newName
action
withOtelServiceName "my.cool.service" $ do
-- initialize the service normally
from hs-opentelemetry.
Nice workaround @parsonsmatt.
Depending on timing issues across applications it looks like you could accidentally pickup the new service name in another process running on the same machine?
from hs-opentelemetry.
@parsonsmatt the bracket
is a bit misleading here, because the environment gets set process-wide, meaning itβs not lexically scoped. Just setting it should be fine, since it will be dropped automatically when ending the process.
from hs-opentelemetry.
Great, I'll make this as closed for now.
from hs-opentelemetry.
Related Issues (20)
- Logging roadmap
- Combining WAI and Yesod instrumentation loses exception details HOT 2
- Support changes in http instrumentation field names
- Support OTEL_SDK_DISABLED
- Unsure if instrumentation-persistent is tracing write operations HOT 1
- Fix code locations for span convenience functions
- Add thread start / thread end hooks to RTS
- Nix utilities
- Help logging to stdout HOT 4
- inSpan without UnliftIO HOT 4
- `CONTRIBUTING.md` is missing
- `hspec` combinators HOT 4
- `hs-opentelemetry-sdk` Haddocks are not rendering on hackage for 0.0.3.5 HOT 1
- Handling `ExitSuccess` gracefully
- Supports GHC 8.10 or 8.12? HOT 1
- Code detection is flaky when you define helpers for `inSpan` HOT 3
- `SpanArguments` with an exception handler HOT 1
- Release propagators-datadog HOT 6
- Where did `inSpan''` go?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hs-opentelemetry.