Coder Social home page Coder Social logo

Comments (5)

Profpatsch avatar Profpatsch commented on July 3, 2024 1

Depending on timing issues across applications it looks like you could accidentally pickup the new service name in another process running on the same machine?

setEnv modifies the process-internal environment mapping.
Only the process and any children should see the new variable name.

from hs-opentelemetry.

parsonsmatt avatar parsonsmatt commented on July 3, 2024

Another way that end users can work-around this is by using setEnv.

withOtelServiceName :: String -> IO a -> IO a
withOtelServiceName newName action =
  -- use bracket to restore the old service name
  bracket (lookupEnv "OTEL_SERVICE_NAME") (setEnv "OTEL_SERVICE_NAME" . fromMaybe "") $ \maybeOldName -> do
    setEnv "OTEL_SERVICE_NAME" newName
    action

withOtelServiceName "my.cool.service" $ do
  -- initialize the service normally

from hs-opentelemetry.

solomon-b avatar solomon-b commented on July 3, 2024

Nice workaround @parsonsmatt.

Depending on timing issues across applications it looks like you could accidentally pickup the new service name in another process running on the same machine?

from hs-opentelemetry.

Profpatsch avatar Profpatsch commented on July 3, 2024

@parsonsmatt the bracket is a bit misleading here, because the environment gets set process-wide, meaning it’s not lexically scoped. Just setting it should be fine, since it will be dropped automatically when ending the process.

from hs-opentelemetry.

solomon-b avatar solomon-b commented on July 3, 2024

Great, I'll make this as closed for now.

from hs-opentelemetry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.