Comments (2)
Hi there, I'm bumping into this currently.
The Yesod middleware could simply
recordException
targeting the WAI trace.
Based on my limited understanding, I think this may be the only option here.
Unfortunately this still results in the WAI middleware setting a
""
span status message rather than a meaningful description.
Can it not also use setStatus
to address this?
I'm picturing something like...
instance Yesod App where
-- ...
yesodMiddleware h = h `onException` \ex -> do
req <- waiRequest
for_ (lookupSpan =<< requestContext req) $ \span -> do
recordException span mempty Nothing ex
setStatus span $ Error $ pack $ displayException ex
from hs-opentelemetry.
Happy to say this seems to work,
I added the following:
instance Yesod App where
-- ...
yesodMiddleware handler =
bugsnagYesodMiddleware (view bugsnagSettingsL)
$ openTelemetryYesodMiddleware
(RouteRenderer routeToRenderer routeToPattern)
$ openTelemetryExceptionMiddleware -- <-- NEW
$ defaultYesodMiddleware handler
openTelemetryExceptionMiddleware :: HandlerFor site res -> HandlerFor site res
openTelemetryExceptionMiddleware = flip withException $ \ex -> do
unless (isHandlerContents ex) $ do
req <- waiRequest
for_ (Trace.lookupSpan =<< Trace.requestContext req) $ \sp -> do
Trace.recordException sp mempty Nothing ex
Trace.setStatus sp $ Trace.Error $ pack $ displayException ex
isHandlerContents :: SomeException -> Bool
isHandlerContents = isJust . fromException @HandlerContents
from hs-opentelemetry.
Related Issues (20)
- Handling `ExitSuccess` gracefully
- Supports GHC 8.10 or 8.12? HOT 1
- Code detection is flaky when you define helpers for `inSpan` HOT 8
- `SpanArguments` with an exception handler HOT 2
- Release propagators-datadog HOT 6
- Where did `inSpan''` go?
- Logging roadmap
- Support changes in http instrumentation field names
- In-memory Processor for testing HOT 2
- Graceful offline behavior
- Conflict marker in `hs-opentelemetry-utils-exceptions.cabal` HOT 3
- Windows support
- Improving project stewardship HOT 6
- Resource Merge Prioritizes Old Resource
- Attribute max length calculation uses the wrong option value
- AWS X-Ray propagator(intent to implement) HOT 4
- Support OTLP 1.x HOT 1
- Trace Id collisions HOT 5
- No way to create links conveniently
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hs-opentelemetry.