Combining WAI and Yesod instrumentation loses exception details about hs-opentelemetry

[pbrisbin]

Hi there, I'm bumping into this currently.

The Yesod middleware could simply recordException targeting the WAI trace.

Based on my limited understanding, I think this may be the only option here.

Unfortunately this still results in the WAI middleware setting a "" span status message rather than a meaningful description.

Can it not also use setStatus to address this?

I'm picturing something like...

instance Yesod App where
  -- ...

  yesodMiddleware h = h `onException` \ex -> do
    req <- waiRequest
    for_ (lookupSpan =<< requestContext req) $ \span -> do
      recordException span mempty Nothing ex
      setStatus span $ Error $ pack $ displayException ex

[pbrisbin]

Happy to say this seems to work,

I added the following:

instance Yesod App where
  -- ...

  yesodMiddleware handler =
    bugsnagYesodMiddleware (view bugsnagSettingsL)
      $ openTelemetryYesodMiddleware
        (RouteRenderer routeToRenderer routeToPattern)
      $ openTelemetryExceptionMiddleware -- <-- NEW
      $ defaultYesodMiddleware handler

openTelemetryExceptionMiddleware :: HandlerFor site res -> HandlerFor site res
openTelemetryExceptionMiddleware = flip withException $ \ex -> do
  unless (isHandlerContents ex) $ do
    req <- waiRequest
    for_ (Trace.lookupSpan =<< Trace.requestContext req) $ \sp -> do
      Trace.recordException sp mempty Nothing ex
      Trace.setStatus sp $ Trace.Error $ pack $ displayException ex

isHandlerContents :: SomeException -> Bool
isHandlerContents = isJust . fromException @HandlerContents