iain / elo Goto Github PK

My game has thousands of daily active users. Elo worked well for a while, but then I started running into issues:

1. Elo::Helper#initialize keeps adding to a class instance variable, the @all array. This makes Elo incompatible with multi-threaded environments (eg JRuby).

2. The @all array never lets go of references, leading to memory bloat.

I resolved both issues by removing the @all array. Maintaining that array (or something like it) seems outside the scope of this gem's responsibilities.

I'll submit a PR shortly.

This might not be appropriate, but if say you have a match that is subsequently removed and there have been more recent matches involving the players, is there a simple way to fix the elo scores?

Hi there,

I have a question about your gem and couldn't find another way to ask it, I hope this is ok:

I'm looking into using your gem - thanks for putting it together! I would like to use it with rails and have the classes descendants of activerecord. Any suggestions on how to modify it to work with rails? I'm sure I could read the source code a bit more and come up with something, but I figured I'd see if you had any input before I started.

I might be able to fork and make those changes if you're interested in interested in putting out an 'elo-rails' gem.

Let me know: alexkbird (at) gmail (dot) com

Cheers,
Alex