i4mi / fhir-resources-r4 Goto Github PK

Momentan ist das ResourceType Property vom Typ string, aber die möglichen Werte sind bekannt und endlich. Könnte man durch ein Enum oder Type ersetzen.

There is an fhir is not defined reference error, when we try to use the enums inside the declared module.
Should be a problem with the resource generation from the definition.json files.

There are some cases, where the type of a key is undefined.

interface Element {
        id?: undefined;
        ...

interface SimpleQuantity extends Quantity {
        comparator?: undefined;
        ...

Should be a problem with the resource generation from the definition.json files.

For example, QuestionnaireItemAnswerOption expects each of the optional Value[x] properties (ValueInteger, ValueDate, ValueCoding, ValueString, etc.) instead of only exactly one of them.
This seems not to be a problem when the value[x] cardinality is 0..1 (e.g. with Observation / value[x]), but only when the cardinality is 1..1.

Not working in NodeJS because NodeJS doesn't support XMLHttpRequest and has to be installed manually and included in the global namespace to work.

Could you update this to make it work with NodeJS?

When the end attribute of a period is only a year (or a year and a month), it is not inclusive.
E.g. the following returns false, but should be true

isInperiod
  ({
    start: '2022',
    end: '2023'
  }, 
  '2023-02-01'
)

Test suite is already adjusted in Branch 34-fix-isInPeriod

The type of the "dimensions" property on the "SampleData" interface is set to "positiveInt".

"positiveInt" is declared as an alias for "string". This results in the "dimensions" property being encoded as "string" when a "SampleData" object is converted to json. This causes the validation of the fhir resource to fail.

I haven't tested this, but I imagine the problem occurs wherever "positiveInt" is used, as well as for other integer types that have been defined as "string".

Using POST results in getting an error message when trying to update a method.

When you run npm run test, it shows that apiMethods.ts has no coverage.

At some time, we should write tests for this.