i2p / i2psam Goto Github PK

StreamSession::connect expects a response even when setting SILENT=true which is never sent by the SAM bridge.

This library was originally written for SAM v3.0. In the intervening time, SAM v3.1 added support for configurable Destination signature types, which enables apps to move away from the default DSA 1024 signature type.

SAM v3.3 enables a single session (and thus Destination) to be used for streams, datagrams and raw simultaneously. This enables applications using the SAM API to maintain a single set of tunnels, and publish a single Destination that can be used for both TCP-like and UDP-like communication over I2P.

Blocks on #1 and #2 because SAM versioning requires that implementations support all features between the minimum and maximum advertised version.

In function StreamSession::createStreamSession the size of the public key is assumed to be I2P_DESTINATION_SIZE ( = 516) which is correct for the old format with the certificate type Null (certificate = 0x000000) but wrong for anything other.
As StreamSession::createStreamSession also hard codes SAM_SIGNATURE_TYPE ( = "EdDSA_SHA512_Ed25519") the resulting public key is too short, as the certificate is now 7 bytes long (0x05 0x0004 0x0007 0x0000)

In function StreamSession::createStreamSession the value SAM_SIGNATURE_TYPE is hard coded.

Something seems wrong with Makefile syntax:

--->  Building libsamcpp
Executing:  cd "/opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_net_libsamcpp/libsamcpp/work/i2psam-49182ee50208baaa94fd43ec25220e87e4c2b00f" && /usr/bin/make -j8 -w libi2psam.a CC="/opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_net_libsamcpp/libsamcpp/work/compwrap/cc/usr/bin/clang" CXX="/opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_net_libsamcpp/libsamcpp/work/compwrap/cxx/usr/bin/clang++" OBJC="/opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_net_libsamcpp/libsamcpp/work/compwrap/objc/usr/bin/clang" OBJCXX="/opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_net_libsamcpp/libsamcpp/work/compwrap/objcxx/usr/bin/clang++" INSTALL="/usr/bin/install -c" 
make: Entering directory `/opt/local/var/macports/build/_opt_svacchanda_SonomaPorts_net_libsamcpp/libsamcpp/work/i2psam-49182ee50208baaa94fd43ec25220e87e4c2b00f'
Makefile:8: *** missing separator.  Stop.

SAM v3.2 added support for:

• Source and destination ports (inside I2P)
• Configurable protocol number for raw datagrams
• Authorization and SSL
• Concurrent pending STREAM ACCEPTs
• Session keep-alive.

Blocks on #1 because SAM versioning requires that implementations support all features between the minimum and maximum advertised version.