Passing options to `GettextParser.po` compiler in `i18nextToGettext` about i18next-gettext-converter

[mvirbicianskas]

I see, it's all very good that it is in the spec (sorry if I came on wrong footing! I'm just not very familiar with the spec), but it would be more awesome to be able to pass options to the parser as well, it's not even a breaking change, just an optional feature 😉

[jamuhl]

If i see it right multiline is in the spec: https://www.gnu.org/software/gettext/manual/html_node/Normalizing.html

so

msgid "Accept offer note"
msgstr ""
"Jetzt bräuchten wir noch ein paar Informationen von Ihnen um die Bestellung "
"abzuschliessen."

is valid - not sure what we can do here as we depend on the gettext-parser and won't build our own solution just to make your translation management happy (try ours https://locize.com - best fit for i18next anyway)

[perrin4869]

@mvirbicianskas, I am more than willing to review and merge a PR with this feature :)

[mvirbicianskas]

Fantastic! But I've never contributed to open source projects yet, I'd be glad to do that, are there any guidelines I should follow? Or just fork it, create upstream, do some changes, push and PR?

[perrin4869]

That's it, that's all there is to it ;)

…

On Fri, Feb 1, 2019, 4:06 PM mvirbicianskas ***@***.*** wrote: Fantastic! But I've never contributed to open source projects yet, I'd be glad to do that, are there any guidelines I should follow? Or just fork it, create upstream, do some changes, push and PR? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#81 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFgdfLnvri4gFH-kb-qsFNi5YBExJVvpks5vI-dygaJpZM4acYOX> .