JSON export should be in V4 format about i18next-gettext-converter

[perrin4869]

hm... maybe this: https://github.com/smhg/gettext-parser/blob/f383dc83b08c21f12a4f9a31ced88d1ce44194b6/lib/poparser.js#L3
I've actually been struggling bundling readable-stream with rollup for a while, it was because it is using circular dependencies.

I did eventually figure out how to bundle it correctly though! Maybe I try to make a proper browser-compatible bundle in this lib

[perrin4869]

A PR would be very very helpful :)

[adrai]

Maybe for inspiration: locize/gettext-converter@d5b29d8

[perrin4869]

Ah I wasn't aware of that repo!
What is the difference with this one? Is there duplication of functionality?

[adrai]

Ah I wasn't aware of that repo! What is the difference with this one? Is there duplication of functionality?

no, it's not exactly the same... locize/gettext-converter was mainly created to be used on client side... and has a different interface and has no CLI

[perrin4869]

Maybe we could collaborate to factor out the common parts into a common lib to reduce duplicate efforts? Not sure if that would make sense though

[adrai]

Maybe we could collaborate to factor out the common parts into a common lib to reduce duplicate efforts? Not sure if that would make sense though

I think there should be no obstacle if i18next-gettext-converter would integrate locize/gettext-converter and if you want you'll be invited to have write access to it...
what do you think?

[perrin4869]

I already have write access, made several maintenance releases for this lib in the past ;)
Could definitely try making this a node cli frontend for locize/gettext-converter. One thing that I noticed, locize/gettext-converter doesn't depend on node-gettext or gettext-parser, unlike this lib... was there some reason locize didn't use those libs?

[adrai]

I already have write access, made several maintenance releases for this lib in the past ;)

I intended write access to locize/gettext-converter ;-)

Could definitely try making this a node cli frontend for locize/gettext-converter. One thing that I noticed, locize/gettext-converter doesn't depend on node-gettext or gettext-parser, unlike this lib... was there some reason locize didn't use those libs?

If I remember correctly there was an issue with some browser integrations... webpack or rollup or similar...

[perrin4869]

@eMerzh Released in v11!

[eMerzh]

thanks, @perrin4869 👏
I'll test that soon