hyrwork / glamorous-native Goto Github PK

Great work getting this going! Opening this to continue discussion from paypal/glamorous#7

I'm going to bow out. @ mention me if you'd like my input! Thanks again. This is fantastic 👏

1. Idea is we need to separate Glamor Rules that are static from those that are not

static

(props) => ({color: props.green ? "green" : "#000"})

dynamic (animated or toggled styles)

(props) => ({top: props.topOffset ? props.topOffset : 0})

Am I right that these need to be handled differently or am I overthinking it. Should we just allow static rules and leave dynamic styles as styleProps or inlineStyles? If not, my suggestion (in master currently) was to have an extra param for dynamic

(props, d) => ({top: props.topOffset ? props.topOffset : 0})

but that's just so I can switch on param length. Seems hacky. Thoughts?