hypothesis / pyramid-sanity Goto Github PK

For: hypothesis/product-backlog#1199

This looks mostly plain sailing, but we might want to have a crack at getting webtest up to 3.9

Both webtest and webob have unreleased 3.9 support in the works:

• https://github.com/Pylons/webtest/blob/master/tox.ini
• https://github.com/Pylons/webob/blob/master/tox.ini

From my testing the latest versions available both support 3.8. webtest supports 3.9, but webob does not. As webtest is our direct dependency I think we can ignore it.

Pyramid actually raises a specific URLDecodeError when there's a badly-encoded path component, but by default it 500s because there isn't a builtin exception view for URLDecodeError. Apps or extensions can register a custom exception view to catch this and turn it into a 400:

@view_config(context=URLDecodeError)
def url_decode_error(request):
    return HTTPBadRequest()

This is simpler than our current invalid_path_info_tween_factory() and is also the right solution according to the Pyramid docs for URLDecodeError and multiple GitHub comments from Pyramid maintainers.

Unfortunately Pyramid does not raise URLDecodeError for badly encoded query params, so that one will still have to be fixed by a tween.

See Pylons/pyramid#312 (comment) (and there are also several other maintainer comments on GitHub telling people to use an exception view for this)