hyperwallet / node-sdk Goto Github PK

Would appreciate it if you could please publish the latest tag.

Thanks

I'm getting this error while hitting createUser api using hyperwallet-sdk. I tried using all of the available program tokens starting with IS.

Hi, it would be awesome to have type definitions for the package. Since I couldn't find any, I'm creating a basic one. If you decide to support it, I can share my draft here.

Hi,

having the client with the encryption data enabled, when requesting some data, i.e. listBankAccounts, and the response is empty (empty object {}), it throws an error when trying to decrypt the body.

The expected behavior is to return an empty body without throwing any error. As it is without activating the encryption data.

The current requests rely on the timeouts defined in the browser or in the OS. When executing requests, I'd like to be able to set custom timeouts to the requests made by superagent:

https://visionmedia.github.io/superagent/#timeouts

request
  .get('/big-file?network=slow')
  .timeout({
    response: 5000,  // Wait 5 seconds for the server to start sending,
    deadline: 60000, // but allow 1 minute for the file to finish loading.
  })
  .then(res => {
      /* responded in time */
    }, err => {
      if (err.timeout) { /* timed out! */ } else { /* other error */ }
  });

This could be passed as options to the hyperwallet constructor or functions. Alternatively we could inject our own instance of superagent which would also give the ability to use custom plugins for superagent

When making a call such as:

hyperwalletManager.getHyperwallet().listUsers({ "email" : emailAddress }, function(err, users){
   ...
});

A TypeError is thrown when no results are returned, due to the fact that the 204 No Content response does not include a "Content-Type" header.

TypeError: Cannot read property 'indexOf' of undefined
      at /Users/aaron/WaitrInc/hyperwallet-node-sdk/src/utils/ApiClient.js:175:88

The following conditional does not check the status code before executing indexOf against the non-existent res.header["content-type"] array.

https://github.com/hyperwallet/node-sdk/blob/master/src/utils/ApiClient.js#L175

I have a PR which fixes this issue and also includes an additional test to cover this case.

Hi there. I'm working on a project that's using the embedded widget to allow users to set up a transfer method. When using the SDK to make the createTransferMethod call, the Json-Cache-Token appears to be delivered as a param; and not in the Headers, as specified by your API documentation. When I made the same call using fetch/Axios, it worked fine and returned the expected 201 response.

For reference, here is the api call as I had it configured (note:

client.createTransferMethod(userToken, jsonCacheToken, data, callback => {
    // response handling
})

And this is the how the call was posted (tokens intentionally obfuscated/shortened):

https://api.sandbox.hyperwallet.com/rest/v3/users/usr-55555/transfer-methods?Json-Cache-Token=95e73149-55555

The result of the issue was that, as expected, the API call to HW returned an error (as it was unable to parse the data contained in the cache token).

Not sure if this can be replicated - or if I'm missing something, but all other SDK calls seem to be working fine. For the time being, I'll keep the fetch option in place. Thanks much.

Per a snyk scan the node-jose version had an infinite loop vulnerability.

more details here - https://security.snyk.io/vuln/SNYK-JS-NODEJOSE-3323847

upgrade the version to 2.2.0

jsonCacheToken should not be a required parameter. I'm implementing a direct integration and parameter should only be required when using the widget.

Passing a high amount when creating a payment (POST https://api.sandbox.hyperwallet.com/rest/v3/users/usr-****/transfer-methods/trm-****) gives the following message:

  {
    message: 'Your attempted transaction has exceeded the approved payout limit; please contact my @CUSTOMER_NAME@ for further assistance.',
    code: 'LIMIT_EXCEEDED'
  }

LIMIT_EXCEEDED error code and actual transaction limit are not documented

I am working on a project that uses the SDK, I have followed the guide on the Readme.md and when I make a call, I get Invalid credentials. I am thinking it is because of the payload encryption as stated here: https://portal.hyperwallet.com/docs/api/v3/overview/payload-encryption. When I informed my boss, he sent this link: https://github.com/hyperwallet/node-sdk/blob/master/test/utils/ApiClient.spec.js#L220. My confusion is this, the entire doc does not show how you can add encryption to the request that you make seamlessly. I don't know if anyone has done that before.

Similar to #16, TypeError will be thrown when any no-content response is returned, e.g. 429. The following return codes are all possible:

https://portal.hyperwallet.com/docs/api/v3/overview/errors

i got this error when using Production Credential to call this resources:

• https://portal.hyperwallet.com/content/api/v3/resources/users/create
• https://portal.hyperwallet.com/content/api/v3/resources/bank-accounts/create?profileType=Individual&accountType=BANK_ACCOUNT&country=United+Kingdom&currency=EUR
• https://portal.hyperwallet.com/content/api/v3/resources/payments/create
• etc

[ { message: 'Please check your login credentials and try again', code: 'INCORRECT_LOGIN_CREDENTIALS' } ]

but it worked fine when i used UAT Credential or use the cURL Mode