hyiso / string_width Goto Github PK

Regarding my comment on #2 i thought i make a separate issue for this.

The following code line replaces all emoji characters with two empty spaces which returns a width of 2 as far as i can see. Is this correct behavior, or a naive implementation?

  input = input.replaceAll(emojiRegex(), '  ');

As i mentioned in #2 , the black square only takes up 1 space in the terminal whilst still being replaced in the emojiRegex call.

As I've learned there are lots of things determining the width of a rendered character, like the Terminal, Font, Unicode version etc. Maybe you could elaborate on the scope or correctness of this method / package.

Squares ▪︎▫︎◻︎◼︎ and arrows ◀︎▶︎ reported with width 2 but only takes up 1 space in the terminal.

There are probably more cases like this. i Pressed the "Character viewer" on my mac and went to "Bullets and stars" to find these.

I've noticed that some characters have different widths based on the Unicode version of the terminal. Would it make sense to make this package handle multiple Unicode versions by passing in a Unicode version argument?

I was trying out your project and found that the "heart hands" emoji 🫶 was reported as 1 in width even though it takes up two spaces in my terminal. It's part of Unicode 14.

The following line is quite performance expensive after doing some profiling:

  input = input.replaceAll(emojiRegex(), '  ');