hwware / redis Goto Github PK

There are at least 2 related issues.
PR: redis#9438

redis#1297
redis#4561

redis#9103

List specific time slowlog

https://university.redis.com/courses/ru101/

https://university.redis.com/courses/ru101/

Regarding to redis#11915

Requirement:

Now RANDOMKEY command return a random key from the currently selected database OR nil when the database is empty
We want to enhancement this command for more features:

1. Add count option to specified number of keys
2. Add duplicate option to allow return duplicated or non-duplicated random key
3. Add pattern option to allow client to specified the key pattern.

The command format could be like this:

RANDOMKEY [COUNT count] [Duplicated ] [Pattern XXXX]
Default: count = 1; non-duplicated; and no patten which means must match exactly keyname

https://www.tcl.tk/man/tcl8.5/tutorial/tcltutorial.html

Used the sentinel debug command to reduce the overall time it takes for sentinel test cases to run.
Test time reduced from 3 minutes to 1 minute 40 seconds in local environment.

PR:
redis#9408

There are some memory leak issue on Ubuntu 18 platform.

[exception]: Executing test client: couldn't fork child process: not enough memory.
couldn't fork child process: not enough memory
while executing
"exec cat $filename"
(procedure "sanitizer_errors_from_file" line 2)
invoked from within
"sanitizer_errors_from_file $stderr"
(procedure "check_sanitizer_errors" line 2)
invoked from within
"check_sanitizer_errors [dict get $config stderr]"
(procedure "kill_server" line 78)
invoked from within
"kill_server $srv"
(procedure "start_server_aof" line 6)
invoked from within
"start_server_aof [list dir $server_path] {
assert_equal 1 [is_alive $srv]
}"
("uplevel" body line 4)
invoked from within
"uplevel 1 $code"
(procedure "test" line 51)
invoked from within
"test {Multi Part AOF can start when we have en empty AOF dir} {
create_aof_dir $aof_dirpath

    start_server_aof [list dir $server_path] ..."
("uplevel" body line 289)
invoked from within

"uplevel 1 $code"
(procedure "tags" line 12)
invoked from within
"tags {"external:skip"} {

# Test Part 1

The problem/use-case that the feature addresses

Current LSET command:

LSET key index element: If key does not exist, return (error) ERR no such key
If key exists, but index out of range return (error) ERR index out of range
If key exists, but type not match, return (error) WRONGTYPE Operation against a key holding the wrong kind of value

We should make the LINDEX has the same return value:

LINDEX key index:

current return value:
If key does not exist, return nil
If key exists, but index out of range, return nil
If key exists, but type not match, return (error) WRONGTYPE Operation against a key holding the wrong kind of value

https://university.redis.com/courses/ru301/

redis#9183

https://university.redis.com/courses/ru101/

redis#9564

https://university.redis.com/courses/ru101/

redis#9605

https://university.redis.com/courses/ru301/

Current slowlog get command return the following 6 values as below:
127.0.0.1:6381[10]> slowlog get

1. 1.(integer) 7
   2.(integer) 1678218844
   3.(integer) 5
   4. 1."client"
   2."getname"
   5. "127.0.0.1:58806"
   6. "MMM"

2. 1.(integer) 6
   2.(integer) 1678218835
   3.(integer) 5
   4. 1."client"
   2."setname"
   3."MMM"
   5. "127.0.0.1:58806"
   6. "MMM"

We need add 2 more values for it:
1. database index value which represents which database client executes the command
2. acl username (default username is "default")

redis#11774

redis#9286

The problem/use-case that the feature addresses
Current command LRANGE
reutnr value is: If key does not exist, return empty array

and in the case: RPUSH mylist "one" "two" "three" "four"，
LRANGE mylist -1 -3
it return empty array as well.
Client can not see the difference, thus suggest to update the return value to return (error) ERR no such key
if If key does not exist

https://university.redis.com/courses/ru101/

redis#9288

Issue:

redis#9071

PR:

redis#9313

redis#8786

PR: redis#9240

https://university.redis.com/courses/ru101/

redis#10747

redis#8789

redis#11749

https://university.redis.com/courses/ru301/

redis#11188

redis#341

The problem/use-case that the feature addresses

LINSERT key <BEFORE | AFTER> pivot element

Current, this command can only insert one element per call.

new feature: make this command can insert multiply values at one time

The problem/use-case that the feature addresses

LINSERT key <BEFORE | AFTER> pivot element

Current, LINSERT can insert one element accoriding to the pivot value

new feature: Create a new command and insert element according to the index
It could be: LINSERTI key <BEFORE | AFTER> pivot element or similar

https://university.redis.com/courses/ru301/

PR: redis#9445

https://university.redis.com/courses/ru101/

PR: redis#9389

https://www.tcl.tk/man/tcl8.5/tutorial/tcltutorial.html

Sentinel tests are already very slow, and we shouldn't slow them much further. Yossigo wants to make this define configurable, at least for testing purposes?

PR:
redis#9291

Reference:
redis#8710
redis#8891