Coder Social home page Coder Social logo

Comments (4)

ypriverol avatar ypriverol commented on June 27, 2024

@edeutsch this is actually a problem in all the other endpoints created by the ambiguity of the USI and the lack of identifiers for PSMs, Peptides, and Proteins. I will vote for not removing the dataset/{accession} endpoint because we would like to have a page in the future like this http://proteomecentral.proteomexchange.org/cgi/GetDataset?ID=PXD010597 returning only one dataset.

from proxi-schemas.

edeutsch avatar edeutsch commented on June 27, 2024

sorry, I was too vague in my report.
I fully agree that /datasets/{identifier} should be a singular Dataset returned
But I note that plain /datasets returns an array of Dataset objects. This is also fine
BUT, the issue is the /spectra does not return an array of spectra. but I think it should.
and /psms does not return an array of psms. but I think it should.
and /peptides does not .... etc.
I believe we agreed in Tokyo that all endpoints performing queries (this excludes /xxx/{identifier}) should return an array of items. Did we not?

from proxi-schemas.

ypriverol avatar ypriverol commented on June 27, 2024

sorry, I was too vague in my report.
I fully agree that /datasets/{identifier} should be a singular Dataset returned
But I note that plain /datasets returns an array of Dataset objects. This is also fine
BUT, the issue is the /spectra does not return an array of spectra. but I think it should.
and /psms does not return an array of psms. but I think it should.
and /peptides does not .... etc.
I believe we agreed in Tokyo that all endpoints performing queries (this excludes /xxx/{identifier}) should return an array of items. Did we not?

@edeutsch I miss array definition, already included in the current PR #42

from proxi-schemas.

edeutsch avatar edeutsch commented on June 27, 2024

I think this is resolved. All endpoints return and array of items except for /xxx/{identifier} is the policy.

from proxi-schemas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.