hunterz / umoria Goto Github PK

Hello All,

First, thank you for the great effort creating a repository for this classic game! That said, I do note something unusual, which may or may not be an issue, in the get_obj_num function (in misc3.c).

In that function, must_be_small is used as one condition, for terminating a loop, but is never modified. Is its purpose to limit the loop to a single iteration (when false)? If so, no problem. Its unclear, from the variable name, if this is the intent.

Apologies, if there was a better place in GitHub to ask questions about potential issues. If this is the case, please let me know where I should do so. I am brand new to this site.

Thank you,
-Eric.

I'm confused about the current license status of Moria. Reading http://free-moria.sourceforge.net/ it seems that respondents variously agreed to Public Domain or GPLv2, and the LICENSE file here indeed has:

GNU GENERAL PUBLIC LICENSE
Version 2, June 1991

But the source file headers say this, which seems contradictory (emphasis added):

Umoria is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

Additionally, on Wikipedia it says this, which is concerning:

Jimmey Wayne Todd Jr., a major contributor to VMS Moria, along with Gary D. McAdoo, are not listed as consenting to the relicense.

Is the GPL licensing of Moria still in a gray area? Is it GPLv2 or GPLv3?

EDIT: See also:
https://www.reddit.com/r/moriarl/comments/7rxwud/umoria_relicense_missing_contributors/
dungeons-of-moria/umoria@24ef243

In file unix.c, line #325, it should read:

while (*file != '/' && i < sizeof(user)-1)

as you are going to add an extra \0 in the end.

Soooooooo... UMoria means Unix Moria, but you've renamed all source code archive files to only be non-Unix (or not for free POSIX-based OSes)--can you really call that ‘official?’