hunterxx222 / react-prework Goto Github PK

Hello Hanoian Champion Toan Ngo.

Good work with the prework, especially the additional features. Interesting implementation on the time feature counting up. One quick suggestion:

Instead of just doing an empty setState, as on https://github.com/hunterxx222/react-prework/blob/master/src/App.js#L29, you should just setState on the current time. https://stackoverflow.com/a/39426527/396324. You can then pass in the current time as a prop to tweet, which I think is much cleaner.

You should also unmount the interval.

https://www.reactenlightenment.com/basic-react-components/6.10.html also has another example of updating using a timer.

Another note is it's not good form to use splice directly on the tweets array in the delete function. Here we're okay, but there are times that you may have a bug where React is confused about whether or not there's a new object. In short: when you mutate an existing object, sometimes React doesn't realize things have changed. The safest way is to create a new "copy" of an object.

Good work! Hope to see more awesome stuff from you, thanks for the cool dynamic timer updating :).