humzashah / convenient_grouper Goto Github PK

Currently the tests are checking the string outputs of a few methods. Modify this so that a real database is involved and the tests verify the records that are being fetched, rather than strings being outputted.

Any one of the following should be sufficient, since the where and group are treated the same: MySQL, PostgreSQL, or SQLite

ALSO: use Minitest rather than RSpec.

Something like this:

age: {
  teen: 13..19,
  greater_than_20: "> 20",
  less_than_50: "< 50"
}

Add >= and <= too.

Accept array of values, arrays, and ranges and auto-name the groups e.g.

Employee.group(id: [1, 2, [3,4], 6..9])

should become something like:

Employee.group(id: {a: 1, b: 2, c: [3,4], d: 6..9})

this entails removing keyword-method-arguments

Disable the default group so that the following commands:

Event.group(date: {not_on_date: ">= #{some_date}"}).count

yield either an empty hash or a hash with only one key which is not_on_date

Enable support for inequality matcher i.e. !=

Employee.group({age: {first: 18}}, restrict: true)

should translate to

Employee.where(age: 18).group(age: {first: 18)

Similarly

Employee.group({age: {first: 18, second: [19, 20], third: 25..30}}, restrict: true)

should restrict the query to employees who are of ages 18, 19, 20, or between 25 and 30.

Technically speaking, the range is not invalid, it's just equivalent to group_name: range.min.

I'm using the gem and generating the groups dynamically and ran into this. It would be nice not to have to change from a range to a value.

So I suggest changing https://github.com/humzashah/convenient_grouper/blob/master/lib/convenient_grouper/hash_converter.rb#L120 to be valid = min && max && (min <= max), what do you think?

I can submit a PR, please let me know.

Thank you!

Rachel