Comments (7)
Hi, I'm not currently available to see your project, but when I'm back at home I will take a look and see what we can do :)
from coinnect.
Agree about the complexity of synchronous vs asynchronous and about the amount of work. This will probably be a long discussion. I just wanted to address the issue for the future.
from coinnect.
I think I have completed the interface for websockets.
I made sure that implementation of new websocket protocols is as simple as possible.
Poloniex is stable and tested, for now there are no plans for other exchanges (you can see beginnings of bitfinex parser though).
If we would like to merge our work together please see protocol buffers messages in orca. RawOrder
, RawTrade
those are very easy to bring to coinnect.
from coinnect.
I already did a simple websocket connection with OKCoin exchange with the rust-websocket crate. So yes it's possible (and fairly simple).
The thing is, websocket does not fit well with the current synchronous implementation of the coinnect api. Maybe we can create a branch that adds a websocket module, but this will be a lot of work.
from coinnect.
I have implemented Poloniex websocket stream.
I would like to discuss moving some code out of orca to coinnect, it doesn't make much of a sense to maintain two clients. Orca is mainly designed to be a platform for building trading software and markets simulations. It has lmdb trades database and in-memory orderbook. It fetches trades history from markets, the parts which could also be moved to coinnect. Not the database although, I don't think coinnect is the right place for that.
Let me know what your thoughts are.
I would also like to hear your opinion about incorporating currency and markets packages into coinnect.
from coinnect.
Yop, for the asynchronous stuff, I have some work on it (See #9 ). Create a good implementation it's harder than what I expected first and I don't have much free time but soon :)
from coinnect.
I am not entirely happy with this interface, but it works.
Some things I do not like in my current implementation
- ~commands should be possible to receive again on disconnect
- some streams respect subscribe commands separate for
Trade
andOrderBook
I would want to see better Currency
and CurrencyPair
implementation in coinnect along with Order
, Trade
and OrderBook
data structures to make it possible to migrate this code to coinnect.
from coinnect.
Related Issues (20)
- Fix credentials format HOT 2
- Establish some workflows HOT 19
- Moving Currency and Pair to Types so all the types live under the same module HOT 5
- Use RustCrypto instead of rust-crypto HOT 4
- BTC fork HOT 3
- temporarily bypass the call rate limit in public query? HOT 10
- Prices in decimal instead of f64 HOT 8
- Replace the time library for chrono HOT 2
- block_or_continue doesn't wait the correct time
- OpenAPI & codegen HOT 7
- Improve configuration and credentials system
- Docs on docs.rs do not work anymore HOT 9
- Proposal to implement async API (Futures) HOT 37
- Next exchange to include? HOT 15
- Bitstamp API methods that require POST parameters are broken HOT 2
- Update TravisCI Rust version HOT 1
- Order type for Poloniex HOT 1
- Return type of return_order_book should not be a Map HOT 4
- Poloniex returnChartData parse error HOT 2
- Error: hmac
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coinnect.