Coder Social home page Coder Social logo

Comments (4)

hugues31 avatar hugues31 commented on May 30, 2024

Using the Deserialize from Serde seems a great idea. However does it break the generic API ? I didn't run tests to check it.

from coinnect.

dovahcrow avatar dovahcrow commented on May 30, 2024

I don't think so. Since the generic API assumes the return type as a Map, so the compiler will infer T as a Map. Then everything falls back to the original Map API.

from coinnect.

dovahcrow avatar dovahcrow commented on May 30, 2024

Actually using generic is just a workaround. Finally, I think we need to type-ify all the return types. Something like this is pretty useful.

from coinnect.

hugues31 avatar hugues31 commented on May 30, 2024

Yes but I think that a strong typed return should be the purpose of the generic API, the raw API, which is lower level, should stay close to the exchange response. Eventually, the Map container may be changed.

from coinnect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.