Comments (4)
Using the Deserialize from Serde seems a great idea. However does it break the generic API ? I didn't run tests to check it.
from coinnect.
I don't think so. Since the generic API assumes the return type as a Map
, so the compiler will infer T
as a Map
. Then everything falls back to the original Map
API.
from coinnect.
Actually using generic is just a workaround. Finally, I think we need to type-ify all the return types. Something like this is pretty useful.
from coinnect.
Yes but I think that a strong typed return should be the purpose of the generic API, the raw API, which is lower level, should stay close to the exchange response. Eventually, the Map container may be changed.
from coinnect.
Related Issues (20)
- Fix credentials format HOT 2
- Establish some workflows HOT 19
- Moving Currency and Pair to Types so all the types live under the same module HOT 5
- Use RustCrypto instead of rust-crypto HOT 4
- BTC fork HOT 3
- temporarily bypass the call rate limit in public query? HOT 10
- Prices in decimal instead of f64 HOT 8
- Replace the time library for chrono HOT 2
- block_or_continue doesn't wait the correct time
- OpenAPI & codegen HOT 7
- Improve configuration and credentials system
- Docs on docs.rs do not work anymore HOT 9
- Proposal to implement async API (Futures) HOT 37
- Next exchange to include? HOT 15
- Bitstamp API methods that require POST parameters are broken HOT 2
- Update TravisCI Rust version HOT 1
- Order type for Poloniex HOT 1
- Poloniex returnChartData parse error HOT 2
- Error: hmac
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coinnect.