hughbarney / atto Goto Github PK

The maximum length of a filename is limited to 255, and exceeding that will cause a buffer-overflow:

   helsinki ~/atto $ ./atto $(perl -e 'print "X" x3333')
   Segmentation fault

Suggest we change b_fname in header.h to a char * instead of a fixed buffer. Then rather than testing if strlen(b_fname)>0, in get_buffer_name() we can test for != NULL, etc.

I'm happy to contribute a pull-request, if you wish. It should be easy to use malloc/free and similar. Hardest part will be avoiding the whitespace changes ;)

Got atto up and running but when I entered text into the scratch buffer nothing would show up.
C-v and other coords did move the cursor but no text would show up when I entered it.
I thought that it might have been my font (dejavu mono) but the font was showing up fine in the modelines.
Then I thought it may have been my terminal colorscheme so I made all of them contrasting, and that too did not change anything.
Any ideas?

When running make install, the makefile is set to install atto into ~/bin (a bin folder or file in the home folder, not the root directory), which isn't even included in PATH.

I've made a pull request that changes it to /usr/local/bin/, like many programs you would usually compile from source do.

Atto leaks a file descriptor for every call to getfilename(), and a further file descriptor if tab completion is used. Additionally, an empty file is left behind in /tmp

Hi,

Inside of atto, I tried to load a ~/file and it says "new file" and is empty.
Though the file exists and is not empty
Thanks

I compiled atto on a RaspberryPi2 (armv7h) with termcap-1.3.1.

When I entered Frække frølår in a buffer, atto displayed Fr kke fr l r but the file had the right contents.

Linking with ncursesw6 instead of curses didn't help.

Any suggestions?