huahouye / jupiter-eclipse-plugin Goto Github PK

If you go to http://jupiter-eclipse-plugin.googlecode.com/svn/trunk/update/
the you get the directory listing.  Do some properties need to be set in
order for the index.html to load?  Users should not be able to browse
through the update site folder.

What steps will reproduce the problem?
1. Opened a sql file in eclipse
2. Selected a line where I want to add a code review comment. I don't have
option in the right click menu to add a review Issue.
3. If I add the review manually(from review table) is not remembering the
file/line where I added the issue.

What is the expected output? What do you see instead?
See a marker where the review was added even if it's a sql script. Also
when I click on the review issue to go in the sql script at that line.

Please use labels and text to provide additional information.

Just a little improvement.  In some cases use of generics makes the code
easier to read when using collections and whatnot.  Since we have
officially dropped the support for Java 1.4 it is time for us to get rid of
all of those warnings about generics!

What steps will reproduce the problem?
1. open a non-java file
2. right click and try to create a jupiter issue
3.

What is the expected output? What do you see instead?
expected to see the "Add review issue.." context menu item.

What version of the product are you using? On what operating system?
3.2.1


Please provide any additional information below.

In the screen with the drop down that allows you to specify the author of
the review session review is spelled wrong next to the drop down.

From Bentley Johnson:
Jupiter opens the Review Perspective as soon as one of the review phases is
selected.  All the other perspectives in Eclipse prompt the user if they
want to switch to that perspective at that time.  Jupiter should prompt the
user so that they can say no.

I believe that Bentley has his own custom perspective made from views from
different perspectives in Eclipse so he doesn't really need the actual
Review Perspective.

Here is some input given by Austen Ito who conducts code review:

[1] The user's guide should talk about the review folder with the
reviewers issues.  They didn't know what it was for and how it needs
to be sent to the moderator via subversion or email or whatever.

[2] Someone said the user's guide wasn't that helpful because there
very brief explanations.  Maybe some pictures could be included, kind
of like the original user's guide that Takuya made.

We should also talk about the .jupiter file.  By default in Eclipse "."
resources are filtered out.  People forget to commit this file sometimes.

I think a new user user guide based of both the short version and Takuya's
old version should be created.

I am using Ubuntu and I have Eclipse 3.3.  When I double-click and open a
Java file it throws the following error:

java.lang.NoClassDefFoundError
at
edu.hawaii.ics.csdl.jupiter.ui.marker.ReviewMarker.updateMarkers(ReviewMarker.ja
va:161)
at
edu.hawaii.ics.csdl.jupiter.ui.marker.MarkerTextPartListener.partOpened(MarkerTe
xtPartListener.java:62)
at org.eclipse.ui.internal.PartListenerList$5.run(PartListenerList.java:132)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
at org.eclipse.core.runtime.Platform.run(Platform.java:857)
at org.eclipse.ui.internal.PartListenerList.fireEvent(PartListenerList.java:57)
at
org.eclipse.ui.internal.PartListenerList.firePartOpened(PartListenerList.java:13
0)
at org.eclipse.ui.internal.PartService.firePartOpened(PartService.java:141)
at
org.eclipse.ui.internal.WorkbenchPagePartList.firePartOpened(WorkbenchPagePartLi
st.java:34)
at org.eclipse.ui.internal.PartList.partOpened(PartList.java:227)
at org.eclipse.ui.internal.PartList.access$0(PartList.java:200)
at org.eclipse.ui.internal.PartList$1.propertyChanged(PartList.java:37)
at
org.eclipse.ui.internal.WorkbenchPartReference.fireInternalPropertyChange(Workbe
nchPartReference.java:372)
at
org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.ja
va:607)
at org.eclipse.ui.internal.EditorReference.getEditor(EditorReference.java:263)
at
org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched(WorkbenchPage.java:2
721)
at
org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2633)
at org.eclipse.ui.internal.WorkbenchPage.access$12(WorkbenchPage.java:2625)
at org.eclipse.ui.internal.WorkbenchPage$10.run(WorkbenchPage.java:2577)
at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:67)
at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2572)
at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2556)
at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2547)
at
org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.
java:298)
at
org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.
java:172)
at org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:194)
at org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:175)
at
org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchRun(SelectionDispatch
Action.java:268)
at
org.eclipse.jdt.ui.actions.SelectionDispatchAction.run(SelectionDispatchAction.j
ava:244)
at
org.eclipse.jdt.internal.ui.packageview.PackageExplorerActionGroup.handleOpen(Pa
ckageExplorerActionGroup.java:316)
at
org.eclipse.jdt.internal.ui.packageview.PackageExplorerPart$5.open(PackageExplor
erPart.java:613)
at org.eclipse.jface.viewers.StructuredViewer$2.run(StructuredViewer.java:820)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
at org.eclipse.core.runtime.Platform.run(Platform.java:857)
at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:46)
at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:193)
at
org.eclipse.jface.viewers.StructuredViewer.fireOpen(StructuredViewer.java:818)
at
org.eclipse.jface.viewers.StructuredViewer.handleOpen(StructuredViewer.java:1079
)
at
org.eclipse.jface.viewers.StructuredViewer$6.handleOpen(StructuredViewer.java:11
83)
at org.eclipse.jface.util.OpenStrategy.fireOpenEvent(OpenStrategy.java:263)
at org.eclipse.jface.util.OpenStrategy.access$2(OpenStrategy.java:257)
at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:297)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1101)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3319)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2971)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2389)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2353)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2219)
at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:466)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:289)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:461)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java
:106)
at
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:153)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(Ecli
pseAppLauncher.java:106)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLau
ncher.java:76)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:363)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.jav
a:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:504)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:443)
at org.eclipse.equinox.launcher.Main.run(Main.java:1169)

I installed it from
http://jupiter-eclipse-plugin.googlecode.com/svn/trunk/site/.  I didn't try
the zip release.

This may no longer apply as the defaults resolutions and whatnot have been
changed in the newer versions of Jupiter.

This should be checked though because it was automatically by passing the
Team Phase because somehow all trivials got marked as valid needs fixing.

After doing a code review on a diffent pc I check out the project on my
computer. But not all issues were shown in the review table.

Eclipse was running with Java 6 update 7 and in the error log occured many
unparseable date exception.

After changing the jre to Java 6 Update 10 the errors were solved.

It seems that the Update 7 can not handle the MESZ time zone. After
changing it to GMT in the review files it worked and all issues were
available. 


What steps will reproduce the problem?
Just start eclipse with an jre1.6 Update 7 and see the error log.

What is the expected output? What do you see instead?
Unparseable date error in the error log.

What version of the product are you using? On what operating system?
Eclipse 3.4 Ganymede with JDK 1.6 Update 7 and Jupiter 3.4

If applicable, what editor does the problem occur in (Jupiter is tested
against the 'Eclipse for RCP/Plug-in Developers' so the editors may vary)?


Please provide any additional information below.
You should use a timezone which is supported in Java 6 Update 7 also.

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


Please use labels and text to provide additional information.

All of the columns fail to sort properly.  The items in the table move
around but do not end up in the correct sort order.

Right-clicking and selecting 'Add Review Issue...' adds a line number to
the new issue.  This is wrong as it is taking the line number from the file
that is open in the editor.  There needs to be a check that the file that
was right clicked is actually the same as the one that is open.  Or there
needs to be some way to tell what was clicked on so the line number doesn't
get associated with the issue.

In Windows if the user has a workspace path containing "\u" (or maybe this
is the case for all escape characters) Jupiter will fail to work properly.
 Most commonly exceptions are shown in the log file and the user is not
able to add any issues.

This issue is Windows specific as Linux and OSX don't use the same slashes
for their paths.

Here is one of the exceptions:
!ENTRY org.eclipse.ui 4 0 2008-05-15 23:58:02.930
!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.NullPointerException
    at
edu.hawaii.ics.csdl.jupiter.util.ReviewDialog.processNonReviewIdNotificationDial
og(ReviewDialog.java:48)
    at
edu.hawaii.ics.csdl.jupiter.util.ReviewDialog.processReviewIdSelectionWizardDial
og(ReviewDialog.java:153)
    at
edu.hawaii.ics.csdl.jupiter.ui.action.ReviewAdditionActionDelegate.determineProj
ectReviewIdReviewerId(ReviewAdditionActionDelegate.java:168)
    at
edu.hawaii.ics.csdl.jupiter.ui.action.ReviewAdditionActionDelegate.run(ReviewAdd
itionActionDelegate.java:81)
    at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:256)
    at
org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionCont
ributionItem.java:545)
    at
org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.
java:490)
    at
org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContribution
Item.java:402)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:938)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3682)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3293)
    at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2389)
    at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2353)
    at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2219)
    at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:466)
    at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:289)
    at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:461)
    at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
    at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java
:106)
    at
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:153)
    at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(Ecli
pseAppLauncher.java:106)
    at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLau
ncher.java:76)
    at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:363)
    at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:504)
    at org.eclipse.equinox.launcher.Main.basicRun(Main.java:443)
    at org.eclipse.equinox.launcher.Main.run(Main.java:1169)

when logging identical issues the issue must be replicated field by field.
it would help when an auto complete would be available at least on the
summary field: auto complete summary based on already entered issues in
this file (or  session)

When trying to continue a Jupiter review after selecting a review phase
nothing happens.  Instead you get the following exception:

java.lang.NullPointerException
at
edu.hawaii.ics.csdl.jupiter.file.PropertyXmlSerializer.newProperty(PropertyXmlSe
rializer.java:68)
at
edu.hawaii.ics.csdl.jupiter.file.PropertyResource.fillReviewIdReviewMap(Property
Resource.java:94)
at
edu.hawaii.ics.csdl.jupiter.file.PropertyResource.getInstance(PropertyResource.j
ava:68)
at
edu.hawaii.ics.csdl.jupiter.file.FileResource.getOpenedAndReviewIdContainedProje
cts(FileResource.java:396)
at
edu.hawaii.ics.csdl.jupiter.ui.menu.PhaseSelectionMenu.doSelectionMenuCommand(Ph
aseSelectionMenu.java:150)
at
edu.hawaii.ics.csdl.jupiter.ui.menu.PhaseSelectionMenu.access$0(PhaseSelectionMe
nu.java:143)
at
edu.hawaii.ics.csdl.jupiter.ui.menu.PhaseSelectionMenu$2.widgetSelected(PhaseSel
ectionMenu.java:126)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:228)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1158)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3401)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3033)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2382)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2346)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2198)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:493)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:288)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:488)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java
:113)
at
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:193)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(Ecli
pseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLau
ncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:382)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.jav
a:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:549)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:504)
at org.eclipse.equinox.launcher.Main.run(Main.java:1236)

I have debugged and Jupiter is doing a lot of unnecessary XML parsing.  The
reading often is a flaw in Jupiter's model and must be addressed.

I suspect Jupiter also shows signs of slower I/O due to JAXB.  JAXB seems
to have the poorest performance and even though it is easy to use I think
it needs to be taken out.  I am opting to use StAX.

Some extra checks will improve Jupiter's performance a little bit by
preventing some unnecessary file I/O.  These initial fixes will appear in
Jupiter 3.4.0.  StAX should also make its appearance in Jupiter 3.4.0.

Actual major changes to the model will be in Jupiter 3.4.1.

A class cast exception is thrown when editing an existing review id.  This
happens when Java files are added to the review id while using the edit
review id dialog.

If you start up Eclipse and then use the toolbar and press "Open/Refresh
Review..." and the Jupiter Perspective hasn't been opened yet there is an
error that pops up that says "Unable to read workbench state".  It says it
can't find the two Jupiter views that appear on the bottom of the Jupiter
perspective.  This only happens the first time.  Even though the error
displays the Jupiter perspective will then open and work just fine.

I believe Jupiter switches to the Review Perspective when selecting a phase
of a review.  However if you are in any other perspective and Add Review
Issue is selected it will open up the Issue Editor and the Issue Table
somewhere in that perspective.  Should Jupiter switch to the Review
Perspective instead?

What steps will reproduce the problem?
1. Create any new jupiter issue
2.
3.

What is the expected output? What do you see instead?
When I look in the eclipse project window, I expect to see that the review
file is modified and I need to check in my change. Instead, in the eclipse
window shows that the review file is unmodified. If I open windows explorer
and go to the file where the review is saved, it does show the file as
modified in tortiose svn. 

What version of the product are you using? On what operating system?
Jupiter 3.3.1 in Eclipse 3.3 with the subversion plug-in subclipse on
Windows NT

Please provide any additional information below.
Thanks in advance!

1. When multiple lines are selected in the editor and a new Jupiter issue
is created, the issue should save the line numbers for the start and end of
the selection. Currently it saves only the start line number.

2. The purple marker should also span aside the same lines that were
selected when the issue was created.

3. It should be possible to change the span later either using the issue
editor or preferably by dragging/extending the purple marker (is that
possible?)

4. Would be nice to attach a single issue to multiple code lines/regions.
Another almost as good alternative would be to be able to easily copy an
issue easily to a new place.

Publish javadoc in SVN repository.

Jupiter currently uses JDOM.  Either investigate using a newer version of
JDOM if generics has been added or follow Hackystat's convention and move
to JAXB.

The version of JDOM being used has no generics and causes many warnings.

From a meeting at 21CSI:

- Allow the user to change the line of of code in a file that an issue is 
associated.
- Perhaps let the line of code be optional?  Allow issue to be a more 'general' 
issue that is linked to 
an entire source file.

Upon creating a new Review ID everything is saved except the description
which changes to "review" no matter what.

Reported by Chris Goy

This happens in the pre-refactored version of Jupiter.  We need to verify
this bug in the refactored version and fix it if it still exists.

The StAX implementation found at http://stax.codehaus.org/ carries the
Apache 2.0 License.

StAX replaces JAXB so it needs to be removed.

It says the license is CPL.  Due to restrictions by Google Code we have
changed this to the Apache 2.0 license.  The Jupiter license file(s) should
be update to reflect this change for consistency.

Double-click on an action item in Review Table pane (does not happen with every 
row), the row 
focus will jump to the other action item. 

What steps will reproduce the problem?
1. Start a Jupiter review session and stop before completing
2. Close Eclipse and shutdown computer
3. Attempt to restart the Jupiter review session (e.g., the next day)

What is the expected output? What do you see instead?

I expect the previous Jupiter review file to be shown and have the ability
to add more issues to the current review file.  However, the new session
creates a new review file, deleting the previous file as soon as a new
issue is documented.

What version of the product are you using? On what operating system?

Jupiter 3.4.0 on Windows XP SP2 

If applicable, what editor does the problem occur in (Jupiter is tested
against the 'Eclipse for RCP/Plug-in Developers' so the editors may vary)?

Eclipse Classic

from About:

Eclipse Platform

Version: 3.4.0.v20080610-9I96EhtEm-T_5LxIsybz-3MdGZmOA3uwv7Ka_M
Build id: I20080617-2000

Please provide any additional information below.

We are using Visual Source Safe 6.0 as version control

I attempted to save the review file and restart, and also without having
the review file in VSS; both with the same result.

Should you need more info please contact me.

Remove code related to the supporting of Jupiter 1 files.

The old format is no longer used and hasn't been used in a while.  Users
will have to use Jupiter 3.2 to view unconverted review files.  Jupiter 3.3
will no longer support them.

Often when I review incremental changes, I do a "Compare
with->Branch/Tag..." on my project.  It'd be great if Jupiter could add an
issue from within the Text Compare and attach it appropriately to the file
being compared.

Update the user manual to reflect any changes to Eclipse 3.4.  Add a new
section to Installation from Update site that deals only with Eclipse 3.4.
 Will rename the existing section to Installation for Eclipse 3.2/3.3.

ReviewIdEditDialog and ReviewIdNewFilePage both use the
FileFolderSelectionDialog.  While this works it, this is discouraged
because it is part of the eclipse "internal" package.  This can be replaced
with pure SWT/JFace dialog code.

lib/icons/jupiter.gif should just be icons/jupiter.gif.

Jupiter Add Review Issue and markers only show up in some editors and not
others.  Is there something we can do to remedy this problem?

For example, Eclipse added an XML editor in 3.3.  Jupiter does not hook
into this but it probably should.  Same goes with the Ant editor.

The documentation for the plugin xml is here:
http://help.eclipse.org/help33/index.jsp

Marking this as an enhancement since there is a workaround that can be used
in the mean time.  Opening any files in the Text Editor will make them work
with Jupiter.

Make sure the default auto update site points to the Jupiter page at Google.

Verify that the update site checking works.

The Review Table list jumps to incorrect item upon double click on item or
upon 'clicking in' or 'selecting text in' the source related to that item.

We are consistantly seeing an issue where we double click on a defect in
the review table (or right-click and select goto).  The correct place in
the code is found.  However, the behaviour of the review table list is
erradic.  It jumps to an unrelated item in the list with the same line
number.  This happens sometimes upon double clicking and other times when
we click in the source file that the item refers to.  Other times, it seems
to happen when we select text in the source file that the item refers to.

In any case, this is a huge problem.  First, it gets very confusing what
item we left off on.  Second, it could lead to assigning a resolution to
the wrong item.  The item it incorrectly jumped to may have been a valid
defect while the one we were reviewing was deemed invalid.  If we didn't
realize that the jump in the list had occurred, we would end up marking a
valid defect as invalid and then not fixing it.

After much testing, it appears that the list jumps to the first occurrence
of that line number in the list, regardless of whether or not it is the
right item or even in the same file.  I'm not sure why the list should be
jumping at all.  I'd prefer the list remain unchanged rather than the item
jumping to the top.  However, if it must jump, jumping to the wrong item is
a huge problem for the reasons already mentioned.

Someone has suggested that Jupiter have a PDF version of the user manual. 
I agree that this is a good thing.  This would be helpful since the wiki
pages are very limited in functionality and things like table of contents
are non-existent.  We used to have an HTML only version of the manual but
even that was a little painful as users would have to download the HTML
file and all the images.

The tools that will be used to accomplish this task are:
wt2db (WikiText to DocBook)
DocMan (DocBook Toolchain Manager)

Essentially what will happen is we will convert the UserGuide.wiki page to
DocBook XML.  From there the DocBook page can be converted to PDF.

This issue was moved from CSDL's bug tracker.  The original bug is here: 
http://hackydev.ics.hawaii.edu:8080/browse/JUP-26.

Dear Takuya and Hongbing 
I want to thank you for the great tool Jupiter. We change now from the usage of 
a pure Excel 
sheet to your tool. The motivation of the developers to use Jupiter instead of 
an Excel list is high. 

There is one topic which I want to mention because it forces us to change your 
source code a 
little bit: Our configuration management system does not permit the usage of a 
minus sign "-" in 
the file name. Actually the build-rules for the file name which holds the 
review remarks seems to 
be fix. It would be better if we could configure a name based on the two items 
"reviewID" and 
"reviewerName". Than we would be able to configure a file name like 
"reviewID_reviewerName.xml" instead of the actual 
"reviewID-reviewerName.review". I think it 
would be nice to have a choice on the build-rule of the file name. 

................................................................. 
Mit freundlichen Grüßen / kind regards, 
Dr. Tino Engländer 
Siemens AG 
Siemens VDO Automotive 
SV I IS 
Philipsstrasse 1 
D-35576 Wetzlar 
Telephone: + 49 6441 370-9050 
Fax: + 49 6441 370-13 9050 
E-Mail: [email protected] 

I think it's a feature request.
our company usually organize a software development "project" as mutilple
eclipse "project", I mean,for example,
we will create a working set,eg, abc_biz,then we have multiple eclipse
projects, so it will look like this in eclipse:
abc_biz
     abc_core
     abc_dal
     abc_model
     abc_ext
     abc_service

I wish to create a review on source files in mulitiple eclipse projects,but
in jupiter, I can only select files in the selected eclipse project.
I think if I can select from all file in the "working set" will work for me.

What version of the product are you using? On what operating system?
jupiter 3.3.1 in eclipse3.3

Since Jupiter is not hosted at Google, we need to comply to its
restriction. Julie and I had the idea to use source code repository to
publish site.xml (Eclipse's manifest file for feature/plug-in update). 

Jupiter distribution strategies are to:

1. upgrade the ZIP file to the download page for binary;
2. use SVN repository for source code;
3. use SVN repository for Eclipse update;
4. use SVN repository and gradually write the wiki document for document. 

In RevisionOperation there is a compilation error on
RemoteAnnotationEditorInput.  I'm not sure what happened to that class but
that code was never finished and is not used.

This bug doesn't seem to surface on all machines.  So far bug reports have
been filed for Eclipse 3.3.0 and Eclipse 3.3.2 on Windows XP.  I am able to
reproduce this on Windows XP using Eclipse 3.3.2.

This issue make take some time to resolve as it isn't consistent across all
computers.

Hi There,

Currently the review wizard has three options: New, Edit, and Remove. 
Would it be nice if there is a Duplicate option available?  It would copy
the reviewers, storage, item entries, default items and filters from the
DEFAULT to the new review so that standards could be applied across
different reviews without reentering them again.

Thanks,
-Enoch-

Jupiter historically include Eclipse's library in source distribution. The
reason is that it supported command-line build and multiple Eclipse
versions (say 2.1 and 3.0), in which APIs changes quite frequently).  Now
it's probably time to get rid of this and enforce a dependency of
ECLIPSE_HOME. Eclipse's APIs are stable and another major release is
probably miles away. We will not no longer work on Eclipse 2.1
compatibility any more. When somebody wants it, we can simply provide
him/her an old version of Jupiter. After making this change, document must
be upgraded and highlighted. 

Under "Download and Install" on the main page it says:

Download and Install
To install Jupiter, download the jar file in the Featured Downloads area
and drop it into your Eclipse plugins directory 

The Featured Downloads shows the file "edu.hawaii.ics.csdl.jupiter_3.4.0.jar"

This would appear to be the jar file the Download and Install Insturctions
talk about.

This however doesn't work.  The jar file for featured downloaded actually
appears to be the jar file that needs to be dropped into eclipse's features
directory.

This still only gives the feature jar, and it won't work without the plugin
jar.  I still needed to get the plugin jar from
http://jupiter-eclipse-plugin.googlecode.com/svn/trunk/site/plugins/

I know this is a website bug and not a program bug, but I couldn't find
anywhere else to submit the problem.  Really enjoy using your product, so
if the web site install directions are stopping others from getting to use
it I thought this was worth reporting. 

Update the Jupiter code base to be compatible with Eclipse 3.3.

This bug was moved from Jupiter's original home at CSDL.  The original bug can 
be found here: 
http://hackydev.ics.hawaii.edu:8080/browse/JUP-28.

If a colon is used in the review id, the *.review file will not be created in 
the directory specified, 
rather it will be created in the same directory as the .jupiter file. The 
review id below will result in 
this behavior on Windows XP, Ecplise 3.1.2, with Jupiter 3.1.6 or Jupiter 
2.2.706.3x. 

Peter 

<?xml version="1.0" encoding="UTF-8"?> 
<Property> 
  <Review id="SR:1 - A software change request"> 
    <Description>SR:1 - A software change request</Description> 
    <Author>peter.eltgroth</Author> 
    <CreationDate format="yyyy-MM-dd :: HH:mm:ss:SSS z">2006-08-03 :: 10:11:41:248 CDT</
CreationDate> 
    <Directory>review</Directory> 
    <Reviewers> 
      <Entry id="peter.eltgroth" name="peter.eltgroth" /> 
    </Reviewers> 
    <Files /> 
    <FieldItems> 
      <FieldItem id="Type" default="item.label.unset"> 
        <Entry name="item.label.unset" /> 
        <Entry name="item.type.label.codingStandards" /> 
        <Entry name="item.type.label.programLogic" /> 
        <Entry name="item.type.label.optimization" /> 
        <Entry name="item.type.label.usability" /> 
        <Entry name="item.type.label.clarity" /> 
        <Entry name="item.type.label.missing" /> 
        <Entry name="item.type.label.irrelevant" /> 
        <Entry name="item.type.label.suggestion" /> 
        <Entry name="item.type.label.other" /> 
      </FieldItem> 
      <FieldItem id="Severity" default="item.severity.label.normal"> 
        <Entry name="item.label.unset" /> 
        <Entry name="item.severity.label.critical" /> 
        <Entry name="item.severity.label.major" /> 
        <Entry name="item.severity.label.normal" /> 
        <Entry name="item.severity.label.minor" /> 
        <Entry name="item.severity.label.trivial" /> 
      </FieldItem> 
      <FieldItem id="Resolution" default="item.label.unset"> 
        <Entry name="item.label.unset" /> 
        <Entry name="item.resolution.label.validNeedsfixing" /> 
        <Entry name="item.resolution.label.validFixlater" /> 
        <Entry name="item.resolution.label.validDuplicate" /> 
        <Entry name="item.resolution.label.validWontfix" /> 
        <Entry name="item.resolution.label.invalidWontfix" /> 
        <Entry name="item.resolution.label.unsureValidity" /> 
      </FieldItem> 
      <FieldItem id="Status" default="item.status.label.open"> 
        <Entry name="item.status.label.open" /> 
        <Entry name="item.status.label.resolved" /> 
        <Entry name="item.status.label.closed" /> 
        <Entry name="item.status.label.reopened" /> 
      </FieldItem> 
    </FieldItems> 
    <Filters> 
      <Phase name="phase.individual" enabled="true"> 
        <Filter name="Interval" value="7" enabled="false" /> 
        <Filter name="Reviewer" value="item.reviewer.label.automatic" enabled="true" /> 
        <Filter name="Type" value="item.label.unset" enabled="false" /> 
        <Filter name="Severity" value="item.label.unset" enabled="false" /> 
        <Filter name="AssignedTo" value="" enabled="false" /> 
        <Filter name="Resolution" value="item.label.unset" enabled="false" /> 
        <Filter name="Status" value="item.status.label.open" enabled="false" /> 
        <Filter name="File" value="" enabled="false" /> 
      </Phase> 
      <Phase name="phase.team" enabled="true"> 
        <Filter name="Interval" value="7" enabled="false" /> 
        <Filter name="Reviewer" value="" enabled="false" /> 
        <Filter name="Type" value="item.label.unset" enabled="false" /> 
        <Filter name="Severity" value="item.label.unset" enabled="false" /> 
        <Filter name="AssignedTo" value="" enabled="false" /> 
        <Filter name="Resolution" value="item.label.unset" enabled="true" /> 
        <Filter name="Status" value="item.status.label.open" enabled="false" /> 
        <Filter name="File" value="" enabled="false" /> 
      </Phase> 
      <Phase name="phase.rework" enabled="true"> 
        <Filter name="Interval" value="7" enabled="false" /> 
        <Filter name="Reviewer" value="" enabled="false" /> 
        <Filter name="Type" value="item.label.unset" enabled="false" /> 
        <Filter name="Severity" value="item.label.unset" enabled="false" /> 
        <Filter name="AssignedTo" value="item.reviewer.label.automatic" enabled="true" /> 
        <Filter name="Resolution" value="item.label.unset" enabled="false" /> 
        <Filter name="Status" value="item.status.label.open" enabled="true" /> 
        <Filter name="File" value="" enabled="false" /> 
      </Phase> 
    </Filters> 
  </Review> 
</Property>