httpolar / genshin.academy

Genshin Impact guides, database and other tools in a form of a web application written in React

GENSHIN.ACADEMY

Tiny database, utilities and guides website for Genshin Impact players in multiple languages!

Bug Reports

Regular issues

If you have found a bug, please, open an issue on this GitHub repository.

How to contribute

That's pretty straight forward! Clone the repo, run yarn install and feel free to prupose your changes via pull requests!

Contribution guidelines

• Commit messages should follow convetions, we are trying to follow theme here.
• Please, try to avoid adding more dependencies, do that only if it's necessary. Thanks you!
• Make sure added features/content doesn't use getServerSideProps or getInitialProps.
• Don't forget about ESLint! We are using it for both formatting and linting purposes. VSCode is highly recommended.
• If you want to add more static images, please, check out StaticPicture component and see how it works. Before doing anything with static images, you should run node generatePublicWebpImages.mjs -o to create optimized versions of added images.
• Feel free to ask questions through GitHub Issues!

Team

LunarMelody

Developer Translator Writer

genshin.academy's Issues

should try to get rid of an anonymous function

https://github.com/kitsune-guuji/genshin.zenless.club/blob/4fbf70a20ada8bfdcaa069ab79179a7a066a017c/pages/guides/index.tsx#L28

useMemo couod probably be used here

https://github.com/kitsune-guuji/genshin.zenless.club/blob/4fbf70a20ada8bfdcaa069ab79179a7a066a017c/pages/guides/index.tsx#L42

[Chrome] Settings page has horizontal scroll bar

visual enhacements

• add transitions between pages
• make mobile modal fade in-out

Amber is a five star :/

Should be a four star

CharacterSchema Birthdays

Accidentally updated birthdays card string with refactor tool

Hydration mismatch on custom domain with auto minification on CloudFlare

https://github.com/kitsune-guuji/genshin.zenless.club/blob/4a6fda0d30380012c4ffebad7aa9a55a71ad78b8/components/Navigation.vue#L16-L22

isDark function causes hydration mismatch in production on CloudFlare

useDeferredValue() could be used instead on guides user input

https://github.com/BinaryKitsune/genshin.zenless.club/blob/2de52dd7a45f70c74fa2747db926e2c3004fb5e2/pages/guides/index.tsx#L23-L26

Birthdays card on home page should support multiple birthdays per one day

Now it shows one of the characters, but should display all characters who have a birthday on that day.

Noelle is missing