hsupipeline / convnwb Goto Github PK

As of scipy version 1.9.0, there is a new 'keepdims' argument in scipy.stats.mode that needs to be set for future-proofing, and will start to fail in scipy version 1.11.0: https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.mode.html

This relates to the use of scipy.stats.mode here:
https://github.com/HSUPipeline/convnwb/blob/main/convnwb/timestamps/align.py#L168

For future scipy usage, this could be updated to:
ixis_mode = stats.mode(ixis, keepdims=True)[0][0]

Or, equivalent updates:
ixis_mode = stats.mode(ixis, keepdims=True).mode[0]
ixis_mode = stats.mode(ixis, keepdims=False).mode

Basically - the fix is easy, but need to decide whether to enforce a specific version of scipy, and/or do a version check.

Need to reconcile / choose a strategy between the SDB object here, and the Paths definitions currently used in Convert T3 & TH.

Finalizing touches for a 0.1.0 release to tag:

• re-organize module
• describe base organization
• add changelog
• tag release

There are a couple dependencies that are only used for very specific things, and could be made optional, in order to keep with tool as something lightweight / easy to install.

Dependencies to make optional:

• pynwb
• sklearn

Note - ideas for 0.2.0 that were here became a bit outdated. Closing this.