hpique / articles Goto Github PK

Thank you for sharing this recommendation:

https://github.com/hpique/Articles/blob/master/Swift/Style%20guide%20for%20functions%20with%20closure%20parameters/Style%20guide%20for%20functions%20with%20closure%20parameters.md

I use lots of onSuccess / onFailure blocks in my network code and it was good to find this analysis.

Unfortunately, an important part of style is: how is everyone else expected to interpret this? May I recommend inclusion of any well known examples in the wild which are currently using this prescribed style.

It is stated:

When performance is a concern, better to use nil as a default value.

There is no proof presented that not executing a nil closure is faster than executing an empty closure.

If such proof does not exist, a better statement might be:

If parts of the function may be skipped when closures are not provided then it is better to use nil as a default value.

In https://github.com/hpique/Articles/blob/master/Swift/Style%20guide%20for%20functions%20with%20closure%20parameters/Style%20guide%20for%20functions%20with%20closure%20parameters.md

Fetching an image is a poor example of an action which you would react to neither upon success nor failure. A better example may be posting an update or sending a ping.

Also, the example seems contrived when there is a check for success == nil && failure == nil for posting an image. A real world application would never do this.

Here is an example of a chaining return that you are talking about.

https://gist.github.com/fulldecent/6d64f86869e5d9d12436

Right now it only supports async. But it is possible to also work with sync returns.

It IS possible to keep this generic! And this implementation works everywhere.

The page is written for "Xcode 6.1 Beta 2".

New versions of Swift have since been released and the information may not be accurate anymore.