hpicgs / node-embed Goto Github PK

• Add NPM package.json file containing all required dependencies
• Adjust README to simply use npm install instead of listing required dependencies

Write this in a new folder (e.g. node-embed-qt-new)

i.e. inside .travis.yml and the cmake files.

When configuring the project on linux, cmake complains it cannot find "FindNodejs.cmake". This is because of a filename case mismatch:

• Find script is named "Findnodejs.cmake"
• Project uses find_package(Nodejs REQUIRED)

Fix the case to make this work on case-sensitive systems (either rename file to FindNodejs.cmake or use 'nodejs' in find_package. I would suggest the latter, because changing only the case of a filename can produce problems with git update on Windows systems, a new checkout of the repository may be needed).

Wrong Repo. Sorry!

should call the refresh function in JS, showcasing back and forth communication between JS and C++

The README suggest to install the required npm packages with npm install. This installs them in the node_modules folder in the current directory. The modules are then not available if the program is build and executed in different directory.

A workaround is to copy the node_modules folder to the directory where the binary is executed.

Adopts changes from here.