hounddd / omnipay-systempay Goto Github PK

in AbstractRequest, the getter for UUID uses setParameter() instead of getParameter

    /**
     * @return AbstractRequest
     */
    public function getUuid()
    {
        return $this->setParameter('vads_trans_uuid');
    }

Hello,

Systempay propose 2 keys for encryption :

• sha1
• sha256

It seems your script is based on an old version of payzen that provided only sha1 support. That method is deprecated, you should use sha256 method instead, or, even better, let the user choose.

Here is the documentation about it : https://paiement.systempay.fr/doc/en-EN/form-payment/standard-payment/computing-the-signature.html

Best regards,

Alex

Hello (it's me again ^^),

Automatic return url to the merchant shop can be very useful in some cases (especially when you don't implement IPN url hum hum 😅)

Systempay allow that by providing extra datas to put on the form, see the documentation here.

It would be great to provide extra option in your plugin that would add that datas to the form.

for example :

$gateway->setAutomaticReturnUrl(true);

or something like that.

Thank you

Handling IPN url is essential when you deal with external payment page like systempay.

Systempay allow to override the IPN return url by passing vads_url_check date to the form. See documentation here.

It seems that this module doesn't handle that variable at all, it seems essential to do it to allow developpers to define the IPN return url the way they want, depending on their shop system constraint.

I believe the variable to do that on omnipay side is 'notifyUrl' (but need to be confirmed)

Thank you

Best regards,