Coder Social home page Coder Social logo

Comments (4)

Dhiraj1405 avatar Dhiraj1405 commented on August 13, 2024 1

For the first point, I agree, that we can have a close icon.
For the second point, let's disable the save button when the job is in a pending state.

from job-manager.

ymaheshwari1 avatar ymaheshwari1 commented on August 13, 2024

@Adameddy26 @Dhiraj1405 I think this modal should have a close button as well, so that user have a direct option to close the modal, instead of him finding a way to the close the modal once opened.

Also in case when a job is in pending state we don't allow user to make any changes in the custom parameters, so having save button will confuse the user about this behaviour.

from job-manager.

amansinghbais avatar amansinghbais commented on August 13, 2024

Based on discription with @Dhiraj1405 sir, we have given two individual copy buttons for required and optional parameters respectively. Because of this we have changed the format for the copied object as object of key value pair as parameter and their value.

from job-manager.

Adameddy26 avatar Adameddy26 commented on August 13, 2024

Changes verified and working fine in release v2.23.1. Hence, closing this ticket.

from job-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.