hotwax / job-manager Goto Github PK

Current behavior

When we use trigger for modal on Job Details page, closing date time modal shows empty modal

Expected behavior

When using trigger, only one modal should get opened

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

As described in official documentation:

Img is a tag that will lazily load an image whenever the tag is in the viewport. This is extremely useful when generating a large list as images are only loaded when they're visible. The component uses Intersection Observer internally, which is supported in most modern browsers, but falls back to a setTimeout when it is not supported.

https://ionicframework.com/docs/api/img

We could check if it works well with our implementation of the Image component and provides desired optimisations:
https://github.com/hotwax/job-manager/blob/main/src/components/Image.vue

Current behavior

When selecting the same timezone as the currently selected timezone in the timezone modal, the api call to set the timezone is being made, that is not needed.

Expected behavior

When selecting the same timezone the api call should not being made.

Steps to reproduce the issue

• Login to the app
• Go to settings page
• Click Change button for changing the timezone
• In the modal, search for the same timezone currently selected and select the timezone in the modal
• See in the network tab that the api call is made, but actually the timezone is not changed as previous and current timezone are same.

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Login Credentials:

• username: aaron.wagner
• password: Aaron@123

What is the motivation for adding/enhancing this feature?

The menu footer should have the option to change product store and Shopify config when there are multiple options. By default product options should be there and if there are multiple product stores & Shopify config then only product store options should exist

For most of the cases either there will be multiple stores or the shopify configs. In any of the scenario right configuration should be there in menu footer

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

Current behavior

While scheduling the job, the current date is highlighted but not selected. So, when the time is selected and set to scheduled it doesn't get scheduled.
Each time, the date needs to select whether it is by default the current date.

Expected behavior

While Scheduling a job, by default current date should be selected and only time needs to be set.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

Expected behavior

Steps to reproduce the issue

1. Navigate to the Initial Load page.
2. Click Import products in Bulk, job configuration chip will appear
   Last run shows no occurrence even if there were jobs scheduled earlier

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

eCom store whole data is getting displayed

Expected behavior

Display store name only

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

When scheduling/cancelling a job using checkbox/toggle and if the api fails then the job state does not gets changed to the previous state untill refresh

Expected behavior

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

What is the motivation for adding/enhancing this feature?

The PO reallocation job doesn't actually solve any problem and may cause confusion for the user. So we should remove it from UI.

Found on the pre-order page at the bottom.

What is the motivation for adding/enhancing this feature?

If the base url is set in env file, skip asking on Login page and showing on settings page. This will allow it easy to deploy app for specific instance as well for

What are the acceptance criteria?

• Adding to .env hides the OMS url input from login as well as settings page
• When not in .env, OMS url input should be available login as well as settings page

Can you complete this feature request by yourself?

• YES
• NO

Additional information

What is the motivation for adding/enhancing this feature?

We should store the draft and pending jobs separately. When getting any job from state, we should check if any pending job, if not then return draft job

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

What is the motivation for adding/enhancing this feature?

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

What is the motivation for adding/enhancing this feature?

If filters are applied on pipeline page, and filters menu is closed then there is no way using which user can directly see that there are filters applied or not.

What are the acceptance criteria?

• Change filter icon color to secondary when any filter is applied

Can you complete this feature request by yourself?

• YES
• NO

Additional information

What is the motivation for adding/enhancing this feature?

With confirmation buttons users can choose to confirm or cancel the date time selected
https://ionicframework.com/docs/api/datetime#showing-confirmation-buttons

What is the motivation for adding/enhancing this feature?

Add following API endpoint to webhookEndpointUrls:

1. subscribeOrderCreateWebhook
2. subscribeOrderReturnWebhook
3. subscribeOrderCancelWebhook
4. subscribeProductCreateWebhook

https://github.com/hotwax/job-manager/blob/main/src/services/WebhookService.ts#L14

Additional information

What is the motivation for adding/enhancing this feature?

User should be able to cancel batch jobs by clicking the cancel icon

What are the acceptance criteria?

• On swipe, a cancel icon should be displayed at the end
• On clicking the icon an alert should be displayed to confirm the cancel action
• On confirm, cancel the job

Can you complete this feature request by yourself?

• YES
• NO

Additional information

Screenshot:

What is the motivation for adding/enhancing this feature?

The functionality of the pre-order page has changed since initial UI

Re-arrange jobs and add new required job options.
Use checkbox instead of dropdown for jobs.

• NO

Figma link: https://www.figma.com/file/bVPRRw282CqGKMdbz7dciH/?node-id=18788%3A56454

What is the motivation for adding/enhancing this feature?

https://www.figma.com/file/bVPRRw282CqGKMdbz7dciH/HC-Ionic-design-system?node-id=23579%3A83419&t=EwnGrKo71tXMohaa-0

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

Current behavior

After multiple login, the shopify product store and config information is not displayed on the menu footer

Expected behavior

In every case, the information should be properly rendered.

Steps to reproduce the issue

• Login into job-manager
• See that shopify information is correctly loaded
• Logout and login again
• Observe that the shopify information is not loaded correctly

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Screenshot:

Current behavior

The build is failing with errors due to multiple use of show-default-buttons

Expected behavior

The build should not fail and no errors must be there

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

Right now selecting "none" in the shop selector in the settings screen gets all jobs regardless of product store.

Expected behavior

Instead, it should only get jobs without any product store entry.

Current behavior

Id and service name are displayed on pending job segment.

Expected behavior

Remove id and service name

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

When setting jobs runtime initially or updating runtime for the existing job, the runtime is set to current time only.

Expected behavior

runtime should be set to user input value

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

What is the motivation for adding/enhancing this feature?

Add an empty state to the pipeline pages when there are no jobs running.

"There are no jobs pending | running right now"

Current behavior

Expected behavior

Job list should reset to initial UI

Steps to reproduce the issue

1. Navigate to the Miscellaneous page.
2. Click on any job and the job configuration card appears
3. Navigate to any other page and navigate back.
   Space for the job configuration card still remains

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

Both date and time are displyed.

Expected behavior

Only display time picker.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

What is the motivation for adding/enhancing this feature?

cancelScheduledJob API adds some more details to job required for future tracking

You need to pass only jobId to it

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

Current behavior

Expected behavior

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

Selecting product store is required for all jobs. user should not be able to schedule job without it.

Expected behavior

An error toast should show up asking user to select product store in settings page.

Toast message: "Please select a shop before scheduling a job."

Can you handle fixing this bug by yourself?

• YES
• [ x] NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

What is the motivation for adding/enhancing this feature?

What are the acceptance criteria?

https://www.figma.com/file/bVPRRw282CqGKMdbz7dciH/HC-Ionic-design-system?node-id=18818%3A59782
https://www.figma.com/file/bVPRRw282CqGKMdbz7dciH/HC-Ionic-design-system?node-id=18863%3A61271

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

Current behavior

In pipeline tab when we search job with a full job name in 'search job'.
It doesn't find a job and shows 'There is no job pending right now' .

Steps to reproduce the issue

E.g Search 'Add pre-order tags' in the 'search job' space of pipeline tab
Job is not found

There are only specific keywords from which we can search job.

Current behavior

There are 2 brokering jobs scheduled in job manager. In the pipeline tab, on selecting brokering filter, it is showing no jobs available.

Expected behavior

If brokering jobs are scheduled in job manager. In the pipeline tab, on checking the brokering filter, it should show jobs which are scheduled.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

What is the motivation for adding/enhancing this feature?

The filters will allow user to get specific jobs based upon the category and pinned jobs
https://www.figma.com/file/bVPRRw282CqGKMdbz7dciH/HC-Ionic-design-system?node-id=23603%3A87300

Additional information

Current behavior

We initially faced issue passing complex data like object, array etc in GET method, and used POST method. With #185, this has been fixed, use GET method to all the API calls that requires data fetching.

Expected behavior

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

The current date picker takes browser time even if the user has set a different timezone.

Expected behavior

It should allot the time based on the timezone and should not pick the browser's time.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

Current behavior

Expected behavior

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

• YES
• NO

Environment details

• Browser:
• OS:
• Code Version:

Additional information

What is the motivation for adding/enhancing this feature?

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

What is the motivation for adding/enhancing this feature?

Right now users can only schedule standard brokering from the routing card. Instead users should be able to schedule all types of brokering by selecting facility and if brokering should only run for un fillable orders.

Drop down includes:
Brokering queue
Pre-order parking
Backorder parking

What are the acceptance criteria?

Implement more jobs section on all pages
Jobs will be fetched based upon job enum type id

What is the motivation for adding/enhancing this feature?

We could have a link to add job run schedule to Google Calendar
https://stackoverflow.com/a/21653600/7130371

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

What is the motivation for adding/enhancing this feature?

What are the acceptance criteria?

• ...

Can you complete this feature request by yourself?

• YES
• NO

Additional information

What is the motivation for adding/enhancing this feature?

UI is already created with #244

Update as need
https://www.figma.com/file/bVPRRw282CqGKMdbz7dciH/HC-Ionic-design-system?node-id=23842%3A83391&t=EwnGrKo71tXMohaa-0

Additional information

Current behavior

Navigate to any page, order, inventory etc where the job is disabled. Try scheduling the job from job configuration section/page, after the success message, again click on save changes it will schedule another instance of the job.

Expected behavior

Users should be allowed to schedule it once only. Save changes should be disabled till current action is not completed and once done job scheduled should be updated through it

What is the motivation for adding/enhancing this feature?

When hosting app, we could provide specific aliases that maps to specific instance baseURL. This will ease accessing app for non hotwax domain instances

What is the motivation for adding/enhancing this feature?

The shop name and other instance info is shown in the footer of the menu. It feels very natural to click it and change the selected shop.

What are the acceptance criteria?

Clicking the ship info in the footer should open an inline popover that lets the user select their shop that they would otherwise have to go into the settings page for.

• ...

What is the motivation for adding/enhancing this feature?

Show abbreviated named offset and unabbreviated named offset
https://moment.github.io/luxon/#/formatting?id=table-of-tokens

Additional information