Coder Social home page Coder Social logo

Comments (3)

asyncLiz avatar asyncLiz commented on June 8, 2024

Hi @cdchow! Yes, the IncludeStylesModule does require the Angular router, since it prepares lazy-loaded components to enable the use of Polymer style modules in them.

Your solution to not import OrigamiModule and instead import the individual modules you use is the correct one.

Is the request to document the @angular/router dependency more clearly, or find a solution that does not require it? Right now if someone uses @uirouter/angular-hybrid, they would be unable to use the @IncludeStyles() decorator.

It might not be a bad idea to think of ways to configure IncludeStylesModule to accept different types of routers outside of the Angular one, or to disable hooking into the Angular router entirely.

from origami.

cdchow avatar cdchow commented on June 8, 2024

Thanks @asyncLiz. Yes, exactly that, to document the dependency more clearly. 🙏

from origami.

asyncLiz avatar asyncLiz commented on June 8, 2024

I've added more documentation, as well as an alternative IncludeStylesNoRouterModule that can be used instead of the one that requires @angular/router.

from origami.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.