Comments (3)
Hi @cdchow! Yes, the IncludeStylesModule
does require the Angular router, since it prepares lazy-loaded components to enable the use of Polymer style modules in them.
Your solution to not import OrigamiModule
and instead import the individual modules you use is the correct one.
Is the request to document the @angular/router
dependency more clearly, or find a solution that does not require it? Right now if someone uses @uirouter/angular-hybrid
, they would be unable to use the @IncludeStyles()
decorator.
It might not be a bad idea to think of ways to configure IncludeStylesModule
to accept different types of routers outside of the Angular one, or to disable hooking into the Angular router entirely.
from origami.
Thanks @asyncLiz. Yes, exactly that, to document the dependency more clearly.
from origami.
I've added more documentation, as well as an alternative IncludeStylesNoRouterModule
that can be used instead of the one that requires @angular/router
.
from origami.
Related Issues (20)
- Failed to compile entry-point @codebakery/origami/styles (module as esm5) due to compilation errors HOT 2
- paper-input-container attach causes "Cannot read property 'addEventListener' of null" HOT 1
- Angular 13 @angular/common Could not resolve dependency HOT 3
- PolymerChanges doesn't exist HOT 1
- Allow project root, app root, and .bowerrc directories for polymer-webpack-loader HOT 9
- Support for embedded media in Polymer elements ? HOT 2
- Unit Tests HOT 3
- Any way to run this with Angular 6? HOT 5
- Instead of `path-cli`, couldn't we use `ng eject` istead? HOT 4
- Docs: Zone.js doesn't play nice with webcomponents HOT 3
- How to use two-way databinding with vaadin-grid-filter for vaadin-grid? HOT 7
- Polyfill utilities throws "TypeError: Cannot read property 'toLowerCase' of undefined" HOT 7
- Dynamic/defer importing the AppModule makes the app failed to compile HOT 4
- Update for Angular 7 support HOT 5
- @IncludeStyles does not work on non-root component HOT 13
- Latest version 3.1.1 causes ERROR ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor HOT 4
- routerLink within <template> HOT 1
- Origami prepare command throwing error with Polymer v3.3.1 HOT 2
- Angular 9 and ivy HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from origami.