Comments (4)
Precisely. While Angular 6 is 100% on my radar, I'm holding off on any major decisions until after IO and Polymer 3's announcement. Then I'll start my investigation into what'd be the best path, keeping backwards compatibility in mind.
from origami.
Yup, instead of patching the CLI you could eject it and add the modifications. The reason I went with patching the CLI is to keep support for all of the ng
commands. The last time I experimented with ng eject
, I lost the ability to do simple things like ng serve
. That, simplicity for adoption, and additional complications were the reason I went the patch route.
If the CLI has changed to better support ejecting, I'd love to hear about it! Ultimately though, the patch will be rendered useless with Polymer 3's release. The patch performs two goals:
- Injecting polymer-webpack-loader to import HTML elements.
- Suppressing CSS warnings about custom variables.
Polymer 3's use of ES modules and movement away from HTML imports with solve 1. 2 has already been solved in a later version of the Angular CLI, but is still there for backwards compatibility.
from origami.
My 'problem' was mostly that I was trying to get it to work with angular.json
and that's when the 'patch' approach is frustrating. But if Polymer 3.0 makes all this obsolete (considering it's launching yesterday or today) I guess that that's not too much of an issue.
from origami.
Closing since v3 no longer patches the CLI
from origami.
Related Issues (20)
- Failed to compile entry-point @codebakery/origami/styles (module as esm5) due to compilation errors HOT 2
- paper-input-container attach causes "Cannot read property 'addEventListener' of null" HOT 1
- Angular 13 @angular/common Could not resolve dependency HOT 3
- Cannot read property 'polyfillWrapFlushCallback' of undefined
- Allow project root, app root, and .bowerrc directories for polymer-webpack-loader HOT 9
- Support for embedded media in Polymer elements ? HOT 2
- Unit Tests HOT 3
- Any way to run this with Angular 6? HOT 5
- Docs: Zone.js doesn't play nice with webcomponents HOT 3
- How to use two-way databinding with vaadin-grid-filter for vaadin-grid? HOT 7
- Polyfill utilities throws "TypeError: Cannot read property 'toLowerCase' of undefined" HOT 7
- Dynamic/defer importing the AppModule makes the app failed to compile HOT 4
- IncludeStylesModule expects RouterModule to be imported. HOT 3
- Update for Angular 7 support HOT 5
- @IncludeStyles does not work on non-root component HOT 13
- Latest version 3.1.1 causes ERROR ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor HOT 4
- routerLink within <template> HOT 1
- Origami prepare command throwing error with Polymer v3.3.1 HOT 2
- Angular 9 and ivy HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from origami.