Comments (10)
@jackcmeyer Creating this based on the comment in #2516
from hospitalrun-frontend.
@nobrayner Are you working on a solution for this?
cc @jackcmeyer @tehKapa
from hospitalrun-frontend.
@morrme no I am not - this was raised as an extra task above and beyond the conversion to RTL
from hospitalrun-frontend.
Hi! If no one's working on this issue I'd be keen to work on it
from hospitalrun-frontend.
Hello,
Looks like this issue is unassigned at the moment -- I'd like to work on it if that is the case. Thanks!
from hospitalrun-frontend.
Hi, could I be assigned to this issue if there's still help wanted?
from hospitalrun-frontend.
@connordmccandless sure
from hospitalrun-frontend.
I fixed the duplicate patient modal so that from the UI, if you're trying to add a patient that could be a duplicate, the modal properly displays. However, I'm having trouble with the test. It seems to me that the test always fails. I changed the code to mark every new patient as a duplicate, so that from the UI, any patient added would prompt the duplicate patient modal. However, the test still did not say that it found the duplicate patient modal, and did not pass.
I was wondering if someone who's more knowledgeable about the testing libraries could take a look at the tests in NewPatient.test.sx and see if they should be functional.
from hospitalrun-frontend.
thanks for the update @connordmccandless. create PR and then we'll see
from hospitalrun-frontend.
@tehKapa PR is created and attached to this issue
from hospitalrun-frontend.
Related Issues (20)
- Imaging Request - requestedBy should store the currently logged in user id HOT 7
- ReportIncident save button always rendered HOT 8
- shortid is deprecated HOT 6
- Lab - In the Request Lab routine make the visit field required HOT 5
- New Imaging Request - required visit not enforced HOT 7
- New Lab Request - required visit not enforced HOT 2
- Focus of menu item "Visits" disappears when I view the details HOT 2
- ViewAppointments Tests Have a Console Error HOT 4
- Test patients/care-goals/CareGoalTab.test.tsx on MacOS runner fails HOT 4
- Lack of Visible Focus - WCAG Success Criterion 2.4.7
- NewLabRequest.test.tsx is flaky HOT 4
- Creating new patient - validation of the phone number is wrong HOT 1
- Creating new patient - validation messages not appropriate HOT 5
- Cancel Button HOT 5
- Update Portuguese translation HOT 8
- Type 'unknown' is not assignable to type '(prevState: ImagingRequestError | undefined) => ImagingRequestError | undefined'.
- Live demo is not working.
- Imrpove UI in sidebar HOT 11
- Error occur in while install and run Hospital Run Frontend HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hospitalrun-frontend.