Coder Social home page Coder Social logo

Comments (10)

nobrayner avatar nobrayner commented on May 28, 2024 1

@jackcmeyer Creating this based on the comment in #2516

from hospitalrun-frontend.

morrme avatar morrme commented on May 28, 2024

@nobrayner Are you working on a solution for this?

cc @jackcmeyer @tehKapa

from hospitalrun-frontend.

nobrayner avatar nobrayner commented on May 28, 2024

@morrme no I am not - this was raised as an extra task above and beyond the conversion to RTL

from hospitalrun-frontend.

acrawford13 avatar acrawford13 commented on May 28, 2024

Hi! If no one's working on this issue I'd be keen to work on it

from hospitalrun-frontend.

Giaddon avatar Giaddon commented on May 28, 2024

Hello,

Looks like this issue is unassigned at the moment -- I'd like to work on it if that is the case. Thanks!

from hospitalrun-frontend.

connordmccandless avatar connordmccandless commented on May 28, 2024

Hi, could I be assigned to this issue if there's still help wanted?

from hospitalrun-frontend.

matteovivona avatar matteovivona commented on May 28, 2024

@connordmccandless sure

from hospitalrun-frontend.

connordmccandless avatar connordmccandless commented on May 28, 2024

I fixed the duplicate patient modal so that from the UI, if you're trying to add a patient that could be a duplicate, the modal properly displays. However, I'm having trouble with the test. It seems to me that the test always fails. I changed the code to mark every new patient as a duplicate, so that from the UI, any patient added would prompt the duplicate patient modal. However, the test still did not say that it found the duplicate patient modal, and did not pass.

I was wondering if someone who's more knowledgeable about the testing libraries could take a look at the tests in NewPatient.test.sx and see if they should be functional.

from hospitalrun-frontend.

matteovivona avatar matteovivona commented on May 28, 2024

thanks for the update @connordmccandless. create PR and then we'll see

from hospitalrun-frontend.

connordmccandless avatar connordmccandless commented on May 28, 2024

@tehKapa PR is created and attached to this issue

from hospitalrun-frontend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.