horizontalsystems / unstoppable-wallet-ios

Multi-wallet for Bitcoin, Ethereum, Binance Smart Chain and other emerging blockchains. Non-custodial storage, decentralized exchange, and extensive analytics for thousands of tokens and NFTs. Implemented on Swift.

Unstoppable Wallet

We dream of a world… A world where private property is untouchable and market access is unconditional.

That obsession led us to engineer a crypto wallet that is equally open to all, lives online forever and unconditionally protects your assets.

It is fully peer-to-peer and works without any centrally managed servers. It can't be stopped, blocked or taken down.

Unstoppable is a powerful non-custodial multi-wallet for Bitcoin, Ethereum, Binance Smart Chain, Avalanche, Solana and other blockchains. It provides non-custodial crypto and NFT storage, on-chain decentralized swaps, institutional grade analytics for cryptocurrency and NFT markets, extensive privacy controls and human oriented design.

• It is built with care and adheres to best programming practices and implementation standards in cryptocurrency world. Fully implemented on Swift.
• It is fully peer-to-peer and works without any centrally managed servers. It can't be stopped, blocked or taken down.

Such approach enables the wallet to operate anywhere and remain censorship-resistant. Only the user is in control of the money.

More at https://unstoppable.money

Download

https://itunes.apple.com/us/app/bank-wallet/id1447619907?ls=1&mt=8

Installation

1. git clone [email protected]:horizontalsystems/unstoppable-wallet-ios.git

2. You need to have Development.xcconfig file for Debug configuration and Production.xcconfig file for Release in UnstoppableWallet/UnstoppableWallet/Configuration. You can use sample configurations in .template.xcconfig files.

3. Open in Xcode and run.

License

This wallet is open source and available under the terms of the MIT License.

unstoppable-wallet-ios's Issues

balance tab: parts of action buttons on coin remain visible in collapsed state

To reproduce

1. on balance tab, open coin cell
2. transition to Transactions tab
3. return to balance tab and open some other coin cell on screen.

Newly generated blocks are not synced correctly when peer is already connected

Steps to reproduce:

• connect to peer
• generate several blocks in blockchain
• see that wallet shows "wrongPreviousHeader" error when trying to sync them

Also please note that these blocks are synced correctly if we reconnect to network and sync them via initial sync.

Add bloom filter when new public keys generated

When new public keys are generated and saved to DB, bloom filter must be updated so that we start receiving blocks and transactions for new keys

Transaction Info (and expanded mode: Full Transaction Info)

The share button should share permanent IPFS permalink to transaction record

zpl://screen?sid=5b96439b0c99e06799f35cf9&pid=5b167c731d079e4122e946b7
zpl://screen?sid=5b9640560335644184df2f60&pid=5b167c731d079e4122e946b7
zpl://screen?sid=5b964054183ac85afe217de2&pid=5b167c731d079e4122e946b7

send controller: validate inputs

When user tries to send currency to someone the wallet should check that:

• a provided address is a valid currency (ex: Bitcoin) address. Same applies to all other currencies as well. If user tries to send BTC to an Ethereum address then a respective error "invalid address" should be shown below the input field.
• display error below input field if the balance is insufficien
• Send button should remain inactive while there are input errors (amount, address)

@TalgatNurdinov please provide the design for the insufficient balance error message to @mNizhurin

@mNizhurin it should be noted that the balance should be calculated on a currency level. In other words, if I am trying to send BTC then we should ensure that there is enough BTC (not the total balance)

Restore Screen minor changes

input fields bg and border (#steel20)

zpl://screen?sid=5b167ca5280d391462929c03&pid=5b167c731d079e4122e946b7

improvement for Paper Key validation

when restoring or importing wallet the inputted values should be validated before we show user a bottom sheet dialog with confirmation boxes.

Slight logic change for "I confirm" bottomsheet alert shown to new users

The alert should be shown in following use cases:

• CREATE WALLET >> click on "Later" >> SHOW ALERT. In this case the alert shouldn't be shown when user tries to BACKUP wallet from settings.
• CREATE WALLET >> click on "Backup" >> enter words and click on confirm >> SHOW ALERT
• RESTORE WALLET >> enter words and click on "Restore" >> SHOW ALERT (provided that entered input terms pass the initial validation)
• Settings >> Security >> Paper Key >> Confirm >> SHOW ALERT (provided that entered input terms pass the initial validation)
• clicking on "Security Center" >> "Paper Key" should ask for PIN (or Touch ID).

Receive controller changes

• aligned to left new title
• in adress use 10...10 characters (if address less than 20 characters show full address. this will be the case with EOS blockchain and perhaps many other in the future)
• remove copy button (make copy instead share button)
• add share icon
  

zpl://screen?sid=5b8fb90de311c97f95cd8518&pid=5b167c731d079e4122e946b7

Outgoing transactions are not marked as "relayed" when they are received back via network

When new transaction is created it is marked as "new".
When we relay this transaction and receive it back - we should mark it as relayed in order to avoid resending it every time peer group is connected.

Calculation fee for transaction with choosing payer.

Refactor output selector. Add transactionSizeCalculator for calculate without make new transaction.

TransactionCreator and TransactionSender

TransactionCreator:

• collects all required data to create transaction (fee rate, addresses)
• should create new transaction using TransactionBuilder.
• after that it saves transaction to DB

TransactionSender:

• listens to DB for "new" transactions and tries to relay them into PeerGroup.

Add to iAdapter and ability to get new address for receiving funds

• Add new method "getAddress()" to iAdapter protocol.
• Implement this method for BitcoinAdapter.

send controller: display error below input field if the balance is insufficient

@TalgatNurdinov please provide the design for the insufficient balance error message to @mNizhurin

@mNizhurin it should be noted that the balance should be calculated on a currency level. In other words, if I am trying to send BTC then we should ensure that there is enough BTC (not the total balance)

Welcome screen minor changes

• App Name color to white
• add decentralized scheme image
• "Decentralized App" text below image should be image as well, like on settings
• rename restore to import wallet

zpl://screen?sid=5b167ca5e66f3e4636801a30&pid=5b167c731d079e4122e946b7

• Backup fontscolor to white
• add backup image

zpl://screen?sid=5b167ca5a18a94793a409932&pid=5b167c731d079e4122e946b7

Add ability to report sync progress from WalletKit

Sync progress should be reported to application in order to able to show it in GUI.

match translation strings format to match that of Android

they should be identical

Database is not cleared on logout

Realm database and any other stored data should be cleared on logout.
WalletKit should have a public "clear" method.

UI issues to complete prior release

• Finalize logo
• Transaction info (apply latest design)
• TX info status indicator: pending, processing, completed
• TX status page: the share buttons should share permanent IPFS permalink to transaction record
• Settings : finish security settings section (release version will have PIN, Touch ID settings for app entry and transaction send actions)
• Settings: remove import wallet section (will be re-added on version 1.1)
• HOME: show info button on non-active currencies.
• Finalize title on coin send/receive controllers
• Finalize design for lock screen
• Finalize the initial wallet restore screens
• Finalize the layout for welcome screen

TransactionInput's Syncer

We need to download all transactions related to "our" transaction inputs in order to be able to display "from address" field for transaction.

change the font color of "description texts"

change the font color of "description texts" on following pages to #grey:

• wallet intro page
• backup wallet,
• backup wallet -> paper keys page
• backup wallet -> submit keys page
• pin pages

prepare App Store listing for Bank Wallet

Validate bitcoin address for send.

Add support for validation mainnet and testnet addresses in send module.

when access to camera is disabled and scan qr is opened there is no way to close it.

Make a left padding size 24px in transaction cell

• Left padding - 24 px
• Return transactions status checkmark
• remove tabs in an empty list

zpl://screen?sid=5b8fc967f9791d2a9292abf1&pid=5b167c731d079e4122e946b7

Send Controller Improvements

Tasks

• Apply new layout
• Send Button should become active when there are no errors:
• when amount is valid (if invalid, display "Balance: xxx" in red) @Dianaaiym
• when address is valid (if invalid, display "Incorrect address") @Dianaaiym
• Exchange Rate
• (if available): all info shown(@TalgatNurdinov provide layout)
• (if not available): don't show rate, don't show base equivalent of fee, make switch inactive(@TalgatNurdinov provide layout)
  -- unavailability of ex rate should not prevent user from sending transaction
• add Transaction Confirmation screen (@TalgatNurdinov provide layout). Make sure it shows destination address.
• transaction fee
• should be obtained from IPFS,
• if not available use last available fee
• if that not available we should allow user to enter fee manually (@TalgatNurdinov that options should be considered in the design)

implement Base Currency setting

Below you will find a list of all controller sent he app where user sees a fiat-currency equivalent of crypto amount.

• send controller
• transactions tab
• settings (base currency selector controller)
• transaction info controller
• transaction status controller

Note that these amounts needs to be requested from the permanent IPFS record for that specific transaction.

@nk-the-crazy currently works on the implementation. followup up with him on the status before you begin working on that ticket. Once implemented we will be able to retrieve things like exchange rate and other transaction data for any blockchain in close tp real-time.

Implement transaction status screen

Transaction status screen opened by clickable status in info. Sender/Receiver and ID addresses clickable for copying. "Block" cell should be disabled when status in processing

Screens

• Transaction Status zpl://screen?sid=5b8f60bd5dd19031dbad0d75&pid=5b167c731d079e4122e946b7
• Transaction status processing zpl://screen?sid=5b8f60be25531c63591f37ad&pid=5b167c731d079e4122e946b7

https://scene.zeplin.io/project/5b167c731d079e4122e946b7

Transfer PeerGroup implementation from Android project

1. Transfer all unit tests related to PeerGroup from Android project.
2. Transfer PeerGroup related code from Android project and make sure that all unit tests are passing.

Implement biometrics.

Add placeholder text on empty transaction page

Change color styles hex

Change

• #lightbackground hex to EBEBF0
• #dark hex to 1f2129

Implement huds

• apply new hoods

Huds (light and dark modes)

• incorrect filling of fields
• incorrect pin
• copy
• success after done

zpl://screen?sid=5b5adcec8e733e2230fdc614&pid=5b167c731d079e4122e946b7

Add leading zeros to private key before signing if needed

Reproduction steps
Network: Testnet
Mnemonic words: rather cricket moon movie material walk settle glide since soldier exact cabbage
Path: m/44'/0'/0'/0/4

HDKeychain class generates the following 31 bytes private key: 4c16165875d0bed9a76e4ba83fae65c80076f60791d956f336a2d7a3b21185

This key is invalid, because Bitcoin requires 32 bytes ECDSA private keys

To make this kind of keys valid, leading zero byte should be added to form: 004c16165875d0bed9a76e4ba83fae65c80076f60791d956f336a2d7a3b21185

Also, make research and find out if it possible to get private keys of any other wrong length

Implement Send Confirmation controller

This controller should open after clicking on send
priority is disabled

zpl://screen?sid=5b8fb90ef82810abf8e13bc0&pid=5b167c731d079e4122e946b7

Setup translations management/admin panel for Bank iOS

We need a solution that integrates with Github and provides an easy admin panel for potential contributors in the future.

Implement Pin Lock feature

The app will require user to enter PIN to open the app.

• implement screens for PIN setup (set new PIN -> confirm PIN)
• implement screens to editing existing PIN (confirm existing PIN -> set new PIN -> confirm new PIN)
• check all PIN states here and make sure that iOS has identical implementation horizontalsystems/unstoppable-wallet-android#117

@TalgatNurdinov please provide designs/assets for this screens

Allow User to choose API for Restore Wallet for BTC / BCH/ DASH

• Restore from API : option may have several options to choose from including our own, for each supported blockchain. If for some reason a public explorer not available or not-responding it shouldn't be possible to proceed with that option. Similar implementation to transaction info data sources.

• At least two API sources should be provided, ideally three

TX info status indicator: pending, processing, completed

Other changes

• Title font size
• From / To font sizes
• Title background height size
• check Date format
• Dark mode colors
• Check right padding of tx status button

zpl://screen?sid=5b960b5fb846d06417cf859a&pid=5b167c731d079e4122e946b7
zpl://screen?sid=5b960b5faebd977fa8229ec0&pid=5b167c731d079e4122e946b7
zpl://screen?sid=5b960b5faef2c264ed54d679&pid=5b167c731d079e4122e946b7

Implement confirm transaction controller after send

This controller show after click on send, where you can see fees. (ignore priority cell)

zpl://screen?sid=5b8fb90ef82810abf8e13bc0&pid=5b167c731d079e4122e946b7 (app link)

Add placeholder text to empty transactions page

refer to @TalgatNurdinov font styling specs

Settings : finish security settings section

Release version will have:

• implement cells as on design mockups
• The "import wallet" setting. clicking on it would show user a confirmation dialog in bottom sheet controller similar to the confirmation dialog shown after the secret key backup. ** (1)This action will remove the currently installed wallet. (2)Backup its secret keys if you want too be able to access that wallet in the future. ""
• clicking on "unlink from this device" would show user same alert as for "import wallet"

Below

zpl://project?pid=5b167c731d079e4122e946b7&seid=5b8fa6c89ac5420ef6557cbe

Make support for witness transaction.

Add w2pkh and w2sh transaction types.
Parsing witness.
Check and extract addresses from witness inputs.

Add translations: German + Russian languages

• add German translations
• add Russian translations

scan QR / scan QR from image

• when user scanning the qr code from Camera app. It should be be suggested to open the QR address in the Bank wallet app

• when scanning payment address QR from scanner
  -- Scan zpl://screen?sid=5b72b882e47db8634b2f1ace&pid=5b167c731d079e4122e946b7
  -- Scan from Gallery zpl://screen?sid=5b72b881e47db8634b2f1aaa&pid=5b167c731d079e4122e946b7

https://scene.zeplin.io/project/5b167c731d079e4122e946b7

Replace app icon

app icon bank.zip

settings minor adjustments

• selected language entry should be shown on language cell on settings
• same applies to selected base currency
• when switching between light/dark modes user should remain on settings page minor design fixes
• move Import Wallet to Security section

AddressManager

AddressManager should be able to:

• listen to incoming "our" transactions and mark Addresses as "used"
• generate new addresses if required

Adapters not initialized after wallet is created or restored.

Adapters should be initialized when MainModule launches, instead of LaunchRouter.

add release version design/layout screen for bank-wallet-ios README file

prepare finalized release version design/layout screen for bank-wallet-ios README file