horizon-games / eth-state-channels-research Goto Github PK

Looking at the server and client library code, I don't think this is working currently. The issue is that the timestamp the server sends back to the clients is time.Now().Unix(). The contract uses now >= timestamp to check if the timestamp has expired or not.

In other words, the contract thinks the timestamp is when the match expires, and the server thinks the timestamp is when the match began.

The server needs to add DGame.MatchDuration() to time.Now().Unix() to align with what the contract expects. This is better than adding it to the check on the contract side because doing it properly like that would require checking that the player is playing the correct game as well.

To add to that, the server should be monitoring exits as well, and cancel any ones for which it possesses a valid signed timestamp of.

c786888 is a work around that removes the public seeds from being a part of the hash signed by the matcher. That commit needs to be reverted, but doing so causes matchHash calls to revert when executed.

Can we update interfaces in https://github.com/horizon-games/arcadeum/tree/master/ethereum/interfaces to the latest revision?