Multiline values of `expression` break Honeycomb WebUI about terraform-provider-honeycombio

[kvrhdn]

I'm not a huge fan of this kind of processing within the provider as it would not be transparent to user. So far we haven't had to modify user input to make it compliant to the API (as far as I can remember at least).
Additionally, if the Honeycomb API and UI start to support newlines (not unlikely imo) the behaviour from the provider would be annoying.

Does wrapping the string with trimspace work? This should remove all spaces and newlines.

My preferred solutions in order:

• if this breaks the Honeycomb UI, the Honeycomb API should refuse this
• we should document a workaround (e.g. if trimspace works)
• maybe we can show a Terraform warning if we detect newlines in the expression field
• we can add a validation rule to the expression field (but I'd like to avoid this as this will require a code change if the API changes)

[vlinevych]

Thanks for your input.

• Honeycomb team is notified and has filed a bug
• trimspace does help
• Documentation update: PR #83

An example of working terraform code:

resource "honeycombio_derived_column" "tmp_action" {
  alias       = "tmp_action"
  dataset     = var.dataset
  description = "SLI: successful action"
  expression  = trimspace(<<EOT
  IF(
    REG_MATCH($request, `PATCH https://www.whatever.[a-z]+:443/gw/api/subscriptions/[0-9]+/bar?`),
    AND(
      OR(
        STARTS_WITH($backend_status_code, "2"), 
        STARTS_WITH($backend_status_code, "3"), 
        STARTS_WITH($backend_status_code, "4")
      ),
      LTE($backend_processing_time, 2)
    )
  )
  EOT
  )
}