Comments (4)
chrisduong
commented on August 23, 2024
1
Hi @kvrhdn, I don't think we should enforce "new creation" when there's a change in the expression. I don't see any risks of updating the Derived Column when there's a change in the Expression.
I meant there's a case we only want to update the expression.
from terraform-provider-honeycombio.
kvrhdn
commented on August 23, 2024
1
Fixed by #78, thanks!
from terraform-provider-honeycombio.
olegy2008
commented on August 23, 2024
Hey @kvrhdn!
Is there any chance to get your opinion about that?
from terraform-provider-honeycombio.
kvrhdn
commented on August 23, 2024
I'm guessing documentation used to say it couldn't be updated. That's how I documented it in go-honeycombio as well
https://github.com/kvrhdn/go-honeycombio/blob/596fd485338ddfd4db58b3b456b3f494a8aff4d4/derived_column.go#L51-L55
Agree the provider should simply update expressions in place.
from terraform-provider-honeycombio.
Related Issues (20)
- honeycombio_trigger example in docs fails at `terraform apply` due to time_range and frequency values
- adding `expand_json_depth` after creation causes drift HOT 1
- honeycombio_query_specification changes not picked up properly HOT 1
- Test issue for Asana
- Testing Asana integration
- honeycombio_dataset - add import support
- client: should escape any query params
- Changing recipient details for Slack type recipient in honeycombio_trigger causes 422 failure HOT 2
- PagerDuty notification recipients don't handle default computed value HOT 2
- Validate derived column expressions during the planning stage HOT 5
- Changing recipient details for Slack type recipient in honeycombio_burn_alert causes 422 failure HOT 1
- Add SLO Data source HOT 2
- Floating point rounding issues in 0.15.x HOT 3
- Expose threshold option to set number of triggers before sending an alert HOT 3
- Support pinning in the Honeycomb.io UI HOT 1
- Make `dataset` optional for the honeycomb_query resource HOT 4
- r/honeycombio_board: removing "graph_settings" from query does not set all values to false
- Legacy `HONEYCOMBIO_APIKEY` environment variable doesn't work anymore
- honeycombio_burn_alert > dynamic `recipient` "Value Conversion Error" HOT 5
- Add Sweepers for test cleanup
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-provider-honeycombio.