Comments (5)
Hi Tyler, thank you for your contributions! This request seems reasonable, I'm actually wondering why it doesn't already work that way... I'll check out your PRs in the next few days, at the latest end of next week.
from terraform-provider-honeycombio.
Hi, @mattjw!
The logic changed in v0.12.0 of the provider as it started doing column deletes and the behaviour of what amounted to "automatic import" is not a normal -- and arguably a dangerous -- Terraform workflow.
For the same reason, I'm pretty against any sort of allow_preexisting
or create_if_missing
options as I don't think they match the general Terraform workflow.
from terraform-provider-honeycombio.
Hi 👋. Has there been a regression with this feature? I've hit a similar 409 error mentioned by the OP, which happens when Terraform tries to provision a column that exists already:
│ Error: 409 Conflict: Could not add or update the column: column already exists with this key_name or alias.
│
│ with honeycombio_column.myservice_columns["mycolumn"],
│ on honeycomb-dashboards.tf line 68, in resource "honeycombio_column" "myservice_columns":
│ 68: resource "honeycombio_column" "myservice_columns" {
This is with v0.15.0 (June 2023) of the provider.
Thanks.
One other suggestion: If the provider does support this "fail gracefully if the column exists" behaviour, I wonder if it should be optional with a flag like allow_preexisting = true
(or a better name :)).
from terraform-provider-honeycombio.
@jharley thanks for the reply. And that makes perfect sense. It did seem a little unusual to me too.
One a related topic, I was wondering if it's possible for the provider to validate the presence of required columns at plan-time? Rather than waiting to get a nasty surprise at apply?
Let me know what you think, and if there's appetite for this I'm happy to raise a feature enhancement request. (Presumably as an issue in this repo?)
from terraform-provider-honeycombio.
We've discussed it a fair bit internally. There is more nuance to it than you may initially expect.
For example: what if the column is being made in the same plan-apply run? How do you detect that properly from inside of a query or derived column and handle the validation case? What about ordering of creation?
That said: I probably should have already opened an issue to show that we are aware of the pain point but it's a difficult thing to solve well. You're more than welcome to open an feature request :)
from terraform-provider-honeycombio.
Related Issues (20)
- adding `expand_json_depth` after creation causes drift HOT 1
- honeycombio_query_specification changes not picked up properly HOT 1
- Test issue for Asana
- Testing Asana integration
- honeycombio_dataset - add import support
- client: should escape any query params
- Changing recipient details for Slack type recipient in honeycombio_trigger causes 422 failure HOT 2
- PagerDuty notification recipients don't handle default computed value HOT 2
- Validate derived column expressions during the planning stage HOT 5
- Changing recipient details for Slack type recipient in honeycombio_burn_alert causes 422 failure HOT 1
- Add SLO Data source HOT 2
- Floating point rounding issues in 0.15.x HOT 3
- Expose threshold option to set number of triggers before sending an alert HOT 3
- Support pinning in the Honeycomb.io UI HOT 1
- Make `dataset` optional for the honeycomb_query resource HOT 4
- r/honeycombio_board: removing "graph_settings" from query does not set all values to false
- Legacy `HONEYCOMBIO_APIKEY` environment variable doesn't work anymore
- honeycombio_burn_alert > dynamic `recipient` "Value Conversion Error" HOT 5
- Add Sweepers for test cleanup
- Column Conditional Create leads to Inifinite cycle of creating/deleting columns HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-provider-honeycombio.