Support Import operations about terraform-provider-honeycombio

[kvrhdn]

Okay, I've quickly added schema.ImportStatePassthrough and I can confirm importing boards works fine 👍🏻 I'll clean that up tomorrow and release it.

Importing triggers should also be possible, it will just a bit more implementation work because we need both the dataset and the ID.

[kvrhdn]

Yeah, that's right. It's something you have to explicitly enable/implement per resource.
Which resource would you like to import?

Since reading honeycombio_board only requires an ID this can be implemented with schema.ImportStatePassthrough.

Importing triggers is a bit more difficult since we need both the ID and the datasaet to retrieve the trigger.

[fitzoh]

Which resource would you like to import?

Primarily interested in boards at the moment (that's the issue I ran into), was torn between opening per resource issues or a blanket one. I could see someone wanting to import a trigger, not really seeing a marker import use case.

Okay, I've quickly added schema.ImportStatePassthrough and I can confirm importing boards works fine 👍🏻 I'll clean that up tomorrow and release it.

Awesome, thanks

Importing triggers should also be possible, it will just a bit more implementation work because we need both the dataset and the ID.

Something like terraform import honeycombio_trigger.whatever <dataset>/<id>?

[kvrhdn]

Primarily interested in boards at the moment (that's the issue I ran into), was torn between opening per resource issues or a blanket one. I could see someone wanting to import a trigger, not really seeing a marker import use case.

Agree. One issue for all imports is fine imo, we can add both implementations simultaneously.

Something like terraform import honeycombio_trigger.whatever <dataset>/<id>?

Yeah, but we have to keep in mind that / is a valid character in a dataset name. I have a dataset named kvrhdn/terraform-provider-honeycombio for example.

But we might be able to write a function that always uses the last / in the string. I think we can assume an ID will only contain alphanumeric characters and especially no /...

[fitzoh]

Yeah, but we have to keep in mind that / is a valid character in a dataset name. I have a dataset named kvrhdn/terraform-provider-honeycombio for example.

Well that's interesting...
So I created a dataset called test/dataset, and the url becomes <team>/datasets/test-dataset.

If I try to create test-dataset later, it appears to just be a noop.

anyways...

But we might be able to write a function that always uses the last / in the string. I think we can assume an ID will only contain alphanumeric characters and especially no /...

Yeah, that sounds reasonable

[kvrhdn]

Well that's interesting...
So I created a dataset called test/dataset, and the url becomes /datasets/test-dataset.

If I try to create test-dataset later, it appears to just be a noop.

Yeah, that's also something I discovered: if you put the dataset in the URL, it has to be sanitized (replace / by -) but if you use it in the body it should stay the same...

go-honeycombio has a little extra logic for this when calling the markers and triggers API
https://github.com/kvrhdn/go-honeycombio/blob/main/client.go#L185

[kvrhdn]

All in all not a lot of work to implement this 😀

I'll add an importer to honeycombio_trigger as well and make a new release tomorrow.

[fitzoh]

sweet, thanks again

[kvrhdn]

Import has been implemented for boards and triggers! 🙂