Comments (3)
What do you mean with pin a specific version, or even provide our own? I'd assume that if you pin the version, this would be a version the user provides.
IMO it makes sense to default to latest
, this way you'll always get bug fixes and I'm not very worried about instabilities being added by Honeycomb.io.
If anyone wants to pick this up:
The download url is currently hardcoded to latest: https://github.com/kvrhdn/gha-buildevents/blob/f9bfe4eb0a4be2a660c40491bd4e6861413e87ca/src/buildevents.ts#L13-L16
We should be able to introduce a new input to specify the version and if a version is specified we can use this url instead:
"https://github.com/honeycombio/buildevents/releases/download/${buildeventsVersion}/buildevents-linux-amd64"
A possible solution would be:
- a new input should be added to
action.yaml
: https://github.com/kvrhdn/gha-buildevents/blob/main/action.yaml#L9 - you can grab them using
core.getInput('<input name>')
, for instance: https://github.com/kvrhdn/gha-buildevents/blob/f9bfe4eb0a4be2a660c40491bd4e6861413e87ca/src/index.ts#L19 - we can extend
install
to accept a parameterversion
https://github.com/kvrhdn/gha-buildevents/blob/f9bfe4eb0a4be2a660c40491bd4e6861413e87ca/src/buildevents.ts#L10 - and then we just have to use a different URL depending on the value of version 🙂
from gha-buildevents.
By provide our own I mean something like scarf-sh@93a8dc3 where we use a version with honeycombio/buildevents#99 added
from gha-buildevents.
Thank you for submitting this issue! In an effort to better respond to new issues, we're closing old, inactive issues like this one. If you feel this is still important to consider, please leave a comment.
from gha-buildevents.
Related Issues (20)
- Add parameter continue-on-error HOT 1
- Be able to deal with slashes '/' in dataset names HOT 2
- Job using matrix report spans in same trace HOT 4
- run_number is not unique enough for trace_id HOT 5
- Improve documentation
- Create buildevents.txt at the start of the run
- Make BUILDEVENTS_FILE an absolute path HOT 2
- Support other architectures
- Allow calling this action without generating an event HOT 3
- [Request]: gracefully stub out non-supported platforms, provide customizable points for custom binary HOT 1
- Test question
- test issue
- test asana gh action
- Allowing custom TRACE_ID to be set HOT 2
- This trace has multiple spans sharing the same non-null span ID. HOT 1
- Automatic instrumentation of workflows?
- Update to run using node20
- The `set-output` command is deprecated and will be disabled soon HOT 1
- Generate Spans for jobs in multi-job flows
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gha-buildevents.