Coder Social home page Coder Social logo

Comments (3)

kvrhdn avatar kvrhdn commented on August 23, 2024 1

What do you mean with pin a specific version, or even provide our own? I'd assume that if you pin the version, this would be a version the user provides.

IMO it makes sense to default to latest, this way you'll always get bug fixes and I'm not very worried about instabilities being added by Honeycomb.io.

If anyone wants to pick this up:

The download url is currently hardcoded to latest: https://github.com/kvrhdn/gha-buildevents/blob/f9bfe4eb0a4be2a660c40491bd4e6861413e87ca/src/buildevents.ts#L13-L16

We should be able to introduce a new input to specify the version and if a version is specified we can use this url instead:

"https://github.com/honeycombio/buildevents/releases/download/${buildeventsVersion}/buildevents-linux-amd64"

A possible solution would be:

from gha-buildevents.

shlevy avatar shlevy commented on August 23, 2024

By provide our own I mean something like scarf-sh@93a8dc3 where we use a version with honeycombio/buildevents#99 added

from gha-buildevents.

dstrelau avatar dstrelau commented on August 23, 2024

Thank you for submitting this issue! In an effort to better respond to new issues, we're closing old, inactive issues like this one. If you feel this is still important to consider, please leave a comment.

from gha-buildevents.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.