Comments (5)
Thanks for the report, I can confirm this happens with my workflows as well.
I think we can either:
add the run ID to the trace components, the trace ID will become:tried this in #17<workflow>-<job>-<run-number>-<matrix-key>-<run ID>
- append a short random ID, I assume the runners will have enough randomness to generate something new every time
- use a completely random trace ID (a UUID for example)
I don't know if there is any drawback related to really long trace ID's, but the first feels most user friendly.
from gha-buildevents.
So adding GITHUB_RUN_ID
to the trace ID does not work, this run ID remains the same across re-runs.
This is also documented that way 😅:
Environment variable | Description |
---|---|
GITHUB_RUN_ID | A unique number for each run within a repository. This number does not change if you re-run the workflow run. |
GITHUB_RUN_NUMBER | A unique number for each run of a particular workflow in a repository. This number begins at 1 for the workflow's first run, and increments with each new run. This number does not change if you re-run the workflow run. |
from gha-buildevents.
So adding
GITHUB_RUN_ID
to the trace ID does not work, this run ID remains the same across re-runs.
which is weird, given the github.run_id
field in my screenshots is different. 🤷♂️
I'd be fine with replacing the whole trace_id with a uuid or the otel style random byte[] string (see https://github.com/honeycombio/buildevents/blob/a29a075b660897b8e610b5ee479015d7da930481/cmd_cmd.go#L71)
from gha-buildevents.
god - I must be really stressed. There is no repo name in the trace-id - and we're running on 50 different repos - no wonder there're collisions. 🤦
from gha-buildevents.
I can confirm this is fixed now. Re-running the workflow creates a unique trace id:
from gha-buildevents.
Related Issues (20)
- Add parameter continue-on-error HOT 1
- Be able to deal with slashes '/' in dataset names HOT 2
- Job using matrix report spans in same trace HOT 4
- Improve documentation
- Create buildevents.txt at the start of the run
- Make BUILDEVENTS_FILE an absolute path HOT 2
- Make buildevents download configurable HOT 3
- Support other architectures
- Allow calling this action without generating an event HOT 3
- [Request]: gracefully stub out non-supported platforms, provide customizable points for custom binary HOT 1
- Test question
- test issue
- test asana gh action
- Allowing custom TRACE_ID to be set HOT 2
- This trace has multiple spans sharing the same non-null span ID. HOT 1
- Automatic instrumentation of workflows?
- Update to run using node20
- The `set-output` command is deprecated and will be disabled soon HOT 1
- Generate Spans for jobs in multi-job flows
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gha-buildevents.