hon1nbo / dotfiles Goto Github PK

The Opal Script does not currently set the the appropriate Kernel Parameter as follows:

llibata.allow_tpm=1

Without this parameter, the system cannot write the ATA command for Self Encrypting Drive (SED) access properly. Currently working to detect TPM presence correctly, and mitigate the edge case that it does not exist on the new system this is being installed on.
Also need to determine the best way to set this. It can be set in a running system setting

/sys/module/libata/parameters/allow_tpm 

to '1'
However, this is not persistent. The recommended way on a Grub system is to add it to the

GRUB_CMDLINE_LINUX_DEFAULT

in /etc/default/grub file. However, there may be some other interfering parameters that need to be investigated first before the scripts arbitrarily do this. Whilst the assumption is usually a clean system that is using Grub, this script would be most useful to still be run at a later date if not on initial system configuration and better still if it can handle a non-grub-2.x bootloader. The decision is to ensure that the script will function at that point.

Some scripts still do not handle exceptions well.
Example:

.scripts/arch/crypto/external_luks_setup.sh

This script still tries to format the mapper device after a failed drive LUKS operation. The script should not proceed to this step after a failed operation. In the event a mapper exists, this could be problematic.
Other scripts may be affected, and this ticket Issue can be updated at a later time.

Man this needs cleanup. Too many private laptops and repos of changes later due to wonky work environemnts. Opening this and Assigning to myself out of hatred and as a reminder to start merging things back as I can.