homeservicesofamerica / styled-material-components Goto Github PK

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because we are using your CI build statuses to figure out when to notify you about breaking changes.

Since we did not receive a CI status on the greenkeeper/initial branch, we assume that you still need to configure it.

If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you don’t want it to run on every branch, you can whitelist branches starting with greenkeeper/.

We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

https://material.io/guidelines/components/text-fields.html#text-fields-layout

https://material.io/guidelines/components/toolbars.html

If Subtitle is used elsewhere besides in Card, it should be broken out and made reusable

Primary is currently in the Card component and should be usable elsewhere

https://material.io/guidelines/components/lists.html

https://material.io/guidelines/components/progress-activity.html#

https://material.io/guidelines/components/lists-controls.html

https://material.io/guidelines/components/chips.html

https://material.io/guidelines/components/widgets.html

https://material.io/guidelines/components/grid-lists.html

https://material.io/guidelines/components/dialogs.html

https://material.io/guidelines/components/menus.html

https://material.io/guidelines/components/bottom-navigation.html#

Title is currently part of the Card component and may need to be broken out to be reused

https://material.io/guidelines/components/tooltips.html

The TextField component, if styled with a background-color (or image) appears above the ink-bar, hiding it completely.

Is this intended?

<TextField
  value={currentObject[item]}
  className="textField"
  fullWidth
/>

.textField {
        background-color: white;
      }

https://material.io/guidelines/components/subheaders.html#

The Horizontal Block is currently part of the Card component and should be broken out to be extended and used in other components

Update the react dependency

https://material.io/guidelines/components/subheaders.html#

https://material.io/guidelines/components/tabs.html#tabs-usage

https://material.io/guidelines/components/pickers.html

https://material.io/guidelines/components/expansion-panels.html

https://material.io/guidelines/components/buttons-floating-action-button.html

The Avatar is currently part of the Card component and should be broken out to be extended and used in other components

MediaItem is currently part of the Card component and should be broken out to be extended and used in other components

https://material.io/guidelines/components/chips.html

https://material.io/guidelines/components/progress-activity.html#

https://material.io/guidelines/components/sliders.html#

https://material.io/guidelines/components/selection-controls.html#

https://material.io/guidelines/components/bottom-sheets.html

https://material.io/guidelines/layout/structure.html#structure-app-bar

https://material.io/guidelines/components/snackbars-toasts.html#snackbars-toasts-usage

https://material.io/guidelines/components/data-tables.html

https://material.io/guidelines/components/steppers.html

https://material.io/guidelines/components/chips.html

https://material.io/guidelines/components/widgets.html

https://material.io/guidelines/components/steppers.html

https://material.io/guidelines/components/pickers.html

Add documentation about what 'version' of material design these components are indexed to.

https://material.io/guidelines/components/sliders.html#

https://material.io/guidelines/components/selection-controls.html#

https://material.io/guidelines/components/subheaders.html#

https://material.io/guidelines/components/sliders.html#

https://material.io/guidelines/components/steppers.html

Media is currently part of the Card component and should be broken out to be extended and used in other components

https://material.io/guidelines/components/selection-controls.html#

https://material.io/guidelines/components/dividers.html

The intention of this issue is to clarify the relationship between this library, [material-components-web]https://github.com/material-components/material-components-web), and material design.

In addition to the discussion about versioning, the impetus behind opening this issue is the following situation. The card demo uses an avatar, which as of right now is defined in this library at src/components/Card/Avatar. It poses a challenge for the following reasons:

• It seems reasonable that someone might want to import a generic Avatar component so it can be used in other contexts, such as list items. As such, there exists an argument for adding it as a component to the styled-material-components library.
• No avatar component exists in the material-components-web package. In fact, no avatar CSS is provided even in the card component. The avatar is defined only inside the demo (see .demo-card__avatar), meaning the avatar is not included in the library.
• The .demo-card__avatar conflicts with the material design spec. In particular, it has a circumference of 2.5rem, while the material design guidelines imply a circumference of 40px (72 - 16 * 2).
• The avatar is also not considered a component in material design.

Given the desire to be programmatic around how to transfer material design into this library, any thoughts on how to approach these conflicting needs?