Cask LuLu: problem with update logic about homebrew-cask

[krehel]

This happened twice in the past week

2.6.0 -> 2.6.1
2.6.1 -> 2.6.2

Both of which we shouldn't be running the uninstall, I agree. But yet it still seemed to trigger. Unless I need to do a complete removal and reinstall to reset something?

[bevanjkay]

The current caskfile does not do anything when upgrading or uninstalling except remove the .app file. So you may have an outdated version in your Caskroom if the upgrade is failing to complete.

https://github.com/Homebrew/homebrew-cask/blob/47092142d74bd8059f553ffccf9a32bdf3d999fe/Casks/l/lulu.rb

There would be more than a handful of apps that provide an "uninstaller" that we don't use because generally speaking, the zap stanza will suffice.
The logic behind homebrew-cask suggests that an uninstall will not remove application files, unless you pass zap.

So we could try to replicate as much logic from the upstream uninstaller as possible to the zap stanza.

It is currently not possible to run the uninstaller in the zap stanza, as it will be removed before getting to it (and therefore not exist when zap is initiated.
When this issue is closed it would be possible - Homebrew/brew#15070

[bevanjkay]

Is there an ongoing issue with the way brew upgrade behaves after removing the uninstall script from lulu?

[krehel]

@bevanjkay - yeah there is an issue still. It didn't wipe my configuration that I could find, but it tried to run an uninstall which failed on ARM due to "bad CPU type in executable" as the uninstaller is an x86_64 specific binary.

I started some time ago to rewrite the uninstall logic into a _flight block and see if we could somehow make the normal uninstall a no-op.

So I think there's something here to fix, but part of it is certainly upstream in adding ARM support for the uninstall / upgrade binary.

[bevanjkay]

@krehel But we aren't running any uninstaller anymore. What you are seeing is a leftover from the previous version of the caskfile.

[kevinm6]

Is there an ongoing issue with the way brew upgrade behaves after removing the uninstall script from lulu?

Since brew upgrade runs brew uninstall first, the app is reset, losing previous data and configuration.

The upgrade for cask LuLu as from the maintainer should be as simple as quit the app and replace it.
Even a upgrade stanza from homebrew should be fine, that runs only on brew upgrade but doesn’t trigger brew uninstall (but I know this is a problem for all the other casks and all the homebrew logic) something like this:

upgrade script: {
    executable: "#{staged_path}/LuLu.app/Contents/MacOS/LuLu",
    args:       ["-upgrade"],
    sudo:       true,
  }

The problem is that even if LuLu maintainer has added support for other CLI args, the useful script for uninstall is always the same problem if brew upgrade runs always brew uninstall first.

uninstall script: {
    executable: "#{staged_path}/LuLu.app/Contents/MacOS/LuLu",
    args:       [“-uninstall"],
    sudo:       true,
  }

[kevinm6]

@krehel But we aren't running any uninstaller anymore. What you are seeing is a leftover from the previous version of the caskfile.

That seems weird.
If brew upgrade runs brew uninstall first, the LuLu uninstall script is triggered, or not?

[krehel]

I'd say also there's different issues at play here. Mine is assuredly an upstream issue as the uninstall needs to be compiled for ARM, I'm just thinking of workarounds.

[kevinm6]

I'd say also there's different issues at play here. Mine is assuredly an upstream issue as the uninstall needs to be compiled for ARM, I'm just thinking of workarounds.

I don’t know what’s happening to you, I don’t have any issue on uninstalling it via Homebrew on ARM.

[krehel]

That adds another twist for me at least. I wonder if when trying to debug this uninstall issue sometime ago I accidentally installed the intel version.

Thanks for the data point on that. I'll investigate my own issue.

[kevinm6]

@krehel maybe, or double check if you made some change to your local tap and you’re using that for LuLu cask installs and update with HOMEBREW_NO_INSTALL_FROM_API=1 set.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[kevinm6]

Not happening lately with last updates.
I'll reopen in case something happens again.