logi-options-plus: uninstall removes user-specific files about homebrew-cask

[jck112]

What's the best solution here?

1. Removing the uninstall script? (e.g. jck112@20a9ac8)
2. Adding a parameter to allow casks to skip uninstall on upgrade (e.g. skip_uninstall_on_upgrade true)?
3. Adding a mechanism to backup/restore files on upgrade?
4. Give up on upgrading logi-options-plus using Homebrew?

[bevanjkay]

Usually we have chosen to not use the in built installer and replicated the functionality in using our uninstall options in Homebrew.

The methods that remove preferences and configuration can be moved to the zap stanza instead of uninstall.

[jck112]

Okay thanks, I went ahead and uploaded #167500 to remove the uninstall script.

[jck112]

This may be more complicated than originally thought. It seems some of the paths and bundle ids have changed since the cask was originally created. There is now an additional "/Applications/Utilities/Logi Options+ Driver Installer.bundle/Logi Options+ Driver Installer.app" that contains a System Extension. For maintainability it's probably best to figure out some way to keep using the script.

[bevanjkay]

While we should look to a better systematic approach, to resolve this in the short-term would require not using the script.
Many apps require changes every now and then to the uninstall stanza as the features change over time, so it is not unique to this situation.

[jck112]

Here are all the files that are installed in the latest version (1.64.527952):
logi-options-plus-files.txt

I updated the pull request with the correct files in the uninstall and zap stanzas. I tested repeated install/uninstall scenarios to ensure user-specific files are preserved correctly.