hollixholton / ecommerce-pattern-library Goto Github PK

I think my Pattern Library turned out relatively decent, it has strong content and design, the colours and photography is cohesive, it is fully responsive and there isn't an overwhelming amount of objects on each page.

However, I definitely had some setbacks throughout the semester with this assignment. The biggest plunder I made during this was not focus on accessibility until the very end. This would have been something that could have gone in when I initially coded some of the pieces but it was clearly not a priority at the time. If I were to re-do this library, I would ask for help more often than I did this time around. I think that there are lots of little imperfections that could have been ironed out had I done that. Another big no-no would be the lack of form errors and just general uselessness of the forms I was able to code. That's something that I definitely need to work on on my own.

Style & design — 3

I think the design aspects of my library are consistent and cohesive, and they represent the brand relatively well. There could be a few little tweaks with the colour scheme (such as use of an accent colour) but over all the design part of the library seems to be somewhat solid.

Patterns — 2

I would give myself a 2 on this because there are some patterns that are missing, and some that I could have spent more time on. There are patterns that weren't used that could be used if I were to make this website for real, which I feel good about, but there aren't many.

Explanations — 2.5

My explanations are decently helpful as they are simple and concise in my opinion. However, some of them where somewhat rushed so I feel like that warrants the docking of a half point.

Accessibility — 1

The accessibility for my pattern library is absolutely atrocious. I struggled a lot with deciding where certain tags should go, and why my skip links never seemed to work no matter what I tried. I definitely do not deserve full grades on this portion of the rubric because there is really not much there to mark.

Semantics — 2

I used a lot of the same html tags that I have used in previous assignments, barely branching out to include new ones. I think this is a safety blanket or comfort level thing and that's something I definitely need to do some work on personally.

Responsiveness — 3

I think one of my Pattern Library's biggest successes is the responsiveness. With the help of my humble servants Gridifier and Modulifier, I think my website looks pretty good on most screen sizes. There is still some awkwardness that lingers but overall I like the way it turned out as far as responsiveness is concerned.

Code Quality — 2

I definitely dropped the ball on accessibility, but my semantics and indentation should be clean and mostly correct. This is another portion I don't think I deserve full grades on, because there are chunks of code that are missing, specifically in the accessibility portion.

Gits & Commits — 2.5

For the most part, I was able to name my commits correctly. I think I could have afforded to make a few more, but I was almost expecting to get to submission day and only have 3 or 4 because I kept forgetting to do it when I wasn't submitting anything with Markbot every week.

18/24 — 75%