Comments (6)
Good Friday should also not be included.
from holidays.
Thanks for reporting this! I'll take a look at this shortly.
from holidays.
Any news on this? Would it be more likely to be fixed with a PR?
from holidays.
@aripollak in the meantime this is how I fixed it:
BusinessTime::Config.load("#{Rails.root}/config/business_time.yml")
# or you can configure it manually: look at me! I'm Tim Ferriss!
# BusinessTime::Config.beginning_of_workday = "10:00 am"
# BusinessTime::Config.end_of_workday = "11:30 am"
# BusinessTime::Config.holidays << Date.parse("August 4th, 2010")
h = Holidays.between(Date.civil(Date.current.year, 1, 1), Date.civil(Date.current.year + 1, 12, 31), :federal_reserve, :observed)
# Eve days and good friday are not actually fed holidays
h.reject{|r| r[:name].include? "Eve" or r[:name].include? "Good Friday" }.map do |holiday|
BusinessTime::Config.holidays << holiday[:date]
end
from holidays.
Sorry dudes, I'll try to take a look at this on the train ride home tonight.
from holidays.
Addressed here: #97
Thanks for your patience! Let me know if you spot anything wrong with what I've pushed up. I'll be pushing a new version of the gem a bit later tonight.
from holidays.
Related Issues (20)
- Get a list of all holidays possible for a given region
- Manage Belgium parent region HOT 1
- I have an issue with columbus day HOT 1
- Version Bump Request HOT 4
- Korea's new year get next year's new year
- Islamic holidays
- Día de los Muertos is not listed
- How to prevent stacked observed holidays HOT 1
- GB Substitute Days over Christmas and New Year HOT 1
- Liberation Day, Region NL
- Queen Elizabeth II passing Bank Holiday HOT 10
- Loading custom holidays clears all the provided definitions? HOT 1
- Strange behavoir with end_of_month HOT 2
- Feast of San Giusto for Trieste, Italy should be on 3rd November
- Shouldn't July 3, 2026 be "Independence Day (observed)" in the US? HOT 2
- Project updates HOT 10
- Hanukkah does not appear in list of holidays HOT 1
- Black Awareness Day is not listed for Brazil HOT 1
- Carnival 2024 Missing from Brazil Holidays Listing HOT 1
- Holidays.on returns results inconsistent with Holidays.between
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from holidays.