Comments (10)
@hlascelles Thanks for the speedy update!
Does this still count as having been fixed without an updated release of this Gem? Without your PR merging to definitions
, and a new release of the Gem, technically this issue hasn't been resolved yet, but closing this issue might give the impression that it has been. Should this issue stay open until a new release has been published?
In the meantime I've taken the additional config you've added to manually provide a definition in our app, but hopefully there'll be a new release of the Gem before then.
from holidays.
@hlascelles Thank you for letting me know that.:)
If you don't mind, could you please submit a PR at holidays/definitions?
from holidays.
@ttwo32 I've updated the definitions for the AU version of this holiday: holidays/definitions#232
from holidays.
Added... holidays/definitions#235
Also, a fix for the KE holidays: holidays/definitions#236
from holidays.
Good point, will leave open!
from holidays.
@hlascelles Looks like this can be closed now as the PR has been merged in the definitions file and this commit ed17774 pulled it altogether.
Only thing I cannot see is a new tagged/released version has not been pushed even though the version has changed.
from holidays.
It has been pushed, the version is v8.6.0
in rubygems. I will update this releases page, sorry about it! Please try pulling it and let us know if it works for you!
from holidays.
@ppeble Yes I was able to pull the gem using bundle update holidays --conservative
and it update from 8.5.0 to 8.6.0.
I just expected to see a tag in releases/tags, but maybe I was confused on that.
Thanks for getting this merged in and published today. Very much appreciated 👍
from holidays.
No, you aren't wrong, I had to add it just now. That's why you couldn't see it, I forgot! Thanks for reminding me. 🙇
from holidays.
Thanks for the gem release! 👍
from holidays.
Related Issues (20)
- Get a list of all holidays possible for a given region
- Manage Belgium parent region HOT 1
- I have an issue with columbus day HOT 1
- Version Bump Request HOT 4
- Korea's new year get next year's new year
- Islamic holidays
- Día de los Muertos is not listed
- How to prevent stacked observed holidays HOT 1
- GB Substitute Days over Christmas and New Year HOT 1
- Liberation Day, Region NL
- Loading custom holidays clears all the provided definitions? HOT 1
- Strange behavoir with end_of_month HOT 2
- Feast of San Giusto for Trieste, Italy should be on 3rd November
- Shouldn't July 3, 2026 be "Independence Day (observed)" in the US? HOT 2
- Project updates HOT 10
- Hanukkah does not appear in list of holidays HOT 1
- Black Awareness Day is not listed for Brazil HOT 1
- Carnival 2024 Missing from Brazil Holidays Listing HOT 1
- Holidays.on returns results inconsistent with Holidays.between
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from holidays.