Changing regions names to be I18n compliant about holidays

[alexdunae]

Thanks for submitting. When you say I18n compliant, are you thinking of the IETF language tags used in HTML or locales in Rails? My understanding is that those are more focused on language and not geography.

One of the things the gem also does is support sub-regions within countries (e.g. us_ca for California), which I don't think would be possible with locales.

It could make sense to provide an additional mapping, however, so you could use pt-BR instead of br and get the same results without needing a special lookup table. What do you think?

[andresilveirah]

Hey @alexdunae, I was thinking about locales in Rails but, as you said, it's more focused on languages instead of geography. And holidays are indeed a geography matter.
But I like your idea of providing an additional mapping, I just don't know how it would fit in the code.

[alexdunae]

I've thought about this off and on for a bit. The locale tags are really focused on language whereas holidays are all about geography and culture. I'm not sure if building in a converter would be possible, since different people would want different mapping. My inclination is that it's best left to individual app developers.

But, feel free to take a run at what that mapping table could look like if you think it could work.